Suppress CID 1523641 - dead code in XPACK#11664
Merged
JosiahWI merged 1 commit intoapache:masterfrom Aug 13, 2024
Merged
Conversation
The variable `use_huffman` is used to decide which branch to take, but is hardcoded to `true`. This has already been suppressed for cppcheck, and Coverity says we can suppress it by declaring the variable with `const`. I think `constexpr` should also work, but I couldn't confirm this.
JosiahWI
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable
use_huffmanis used to decide which branch to take, but is hardcoded totrue. This has already been suppressed for cppcheck, and Coverity says we can suppress it by declaring the variable withconst. I thinkconstexprshould also work, but I couldn't confirm this.