Fix CID 1523641 - unchecked error return#11665
Merged
JosiahWI merged 1 commit intoapache:masterfrom Aug 13, 2024
Merged
Conversation
We should abort the test if `written` indicates an error, otherwise we will call `memcmp` later with the value we didn't intend to be negative. This is already done correctly in all the other tests.
moonchen
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should abort the test if
writtenindicates an error, otherwise we will callmemcmplater with the value we didn't intend to be negative. This is already done correctly in all the other tests.