Skip to content

Fix whats-new links and remove redundant timeout#11707

Merged
bneradt merged 1 commit intoapache:masterfrom
bneradt:fix_broken_whats_new_link_references
Aug 17, 2024
Merged

Fix whats-new links and remove redundant timeout#11707
bneradt merged 1 commit intoapache:masterfrom
bneradt:fix_broken_whats_new_link_references

Conversation

@bneradt
Copy link
Copy Markdown
Contributor

@bneradt bneradt commented Aug 16, 2024

whats-new has malformed link references to non-existent links. This fixes that. Also connect_attempts_timeout changes are referenced twice in upgrading in a way that doesn't seem helpful: we say first that we removed them, then in a separate bullet we say that they are removed from default config. The latter is implied by the former.

@bneradt bneradt added this to the 10.1.0 milestone Aug 16, 2024
@bneradt bneradt self-assigned this Aug 16, 2024
@maskit
Copy link
Copy Markdown
Member

maskit commented Aug 16, 2024

The line between upgrading and whats-new is getting blurry. I thought whats-new only have things purely new (i.e. upgrading without reading whats-new doesn't harm anything).

@bneradt
Copy link
Copy Markdown
Contributor Author

bneradt commented Aug 16, 2024

The line between upgrading and whats-new is getting blurry. I thought whats-new only have things purely new (i.e. upgrading without reading whats-new doesn't harm anything).

Yeah, I was just fixing the formatting there. Want me to remove that section all together? It's already covered in upgrading. It seems to me that it doesn't belong in "whats new".

@maskit
Copy link
Copy Markdown
Member

maskit commented Aug 16, 2024

Yeah, that's what implied. If we remove either of them I'd remove the one in whats-new.

@bneradt bneradt force-pushed the fix_broken_whats_new_link_references branch 2 times, most recently from af0b97e to f1c1788 Compare August 16, 2024 18:38
@bneradt
Copy link
Copy Markdown
Contributor Author

bneradt commented Aug 16, 2024

Yeah, that's what implied. If we remove either of them I'd remove the one in whats-new.

Gotcha. Thanks for the thought. Updated with the removal of the section.

whats-new has malformed link references to non-existent links. This
simply removes that section with the broken links because it is
redundant with the references to the change in upgrading. Also
connect_attempts_timeout changes are referenced twice in upgrading in a
way that doesn't seem helpful: we say first that we removed them, then
in a separate bullet we say that they are removed from default config.
The latter is implied by the former.
@bneradt bneradt force-pushed the fix_broken_whats_new_link_references branch from f1c1788 to 9fb403d Compare August 16, 2024 22:11
@bneradt bneradt merged commit a66da2d into apache:master Aug 17, 2024
@bneradt bneradt deleted the fix_broken_whats_new_link_references branch June 17, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: picked-10.0.0

Development

Successfully merging this pull request may close these issues.

3 participants