Skip to content

TS-4957: Make the use of madvise() with MADV_DONTDUMP configurable. #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PSUdaemon merged 1 commit into from
Nov 2, 2016
Merged

TS-4957: Make the use of madvise() with MADV_DONTDUMP configurable. #1171

PSUdaemon merged 1 commit into from
Nov 2, 2016

Conversation

@jrushford
Copy link
Contributor

@jrushford jrushford commented Nov 2, 2016

(cherry picked from commit 514d3fd)

Backport PR to 6.2.x

@jrushford jrushford added this to the 6.2.1 milestone Nov 2, 2016
@jrushford jrushford added the Backport Marked for backport for an LTS patch release label Nov 2, 2016
@atsci
Copy link

atsci commented Nov 2, 2016

FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1143/ for details.

@jrushford
Copy link
Contributor Author

jrushford commented Nov 2, 2016

This PR is for backport to 6.2.1

@zwoop
Copy link
Contributor

zwoop commented Nov 2, 2016 •
edited
Loading 

EventSystem.o
../../../iocore/eventsystem/EventSystem.cc:38:7: error: unused variable 'iobuffer_advice' [-Werror,-Wunused-variable]
  int iobuffer_advice          = 0;
      ^

@atsci
Copy link

atsci commented Nov 2, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1036/ for details.

@jrushford
Copy link
Contributor Author

jrushford commented Nov 2, 2016

oops

From: Leif Hedstrom notifications@github.com
Reply-To: apache/trafficserver reply@reply.github.com
Date: Wednesday, November 2, 2016 at 12:01 PM
To: apache/trafficserver trafficserver@noreply.github.com
Cc: John Rushford John_Rushford@cable.comcast.com, Author author@noreply.github.com
Subject: Re: [apache/trafficserver] TS-4957: Make the use of madvise() with MADV_DONTDUMP configurable. (#1171)

EventSystem.o
../../../iocore/eventsystem/EventSystem.cc:38:7: error: unused variable 'iobuffer_advice' [-Werror,-Wunused-variable]
int iobuffer_advice = 0;
^

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@jrushford
Copy link
Contributor Author

jrushford commented Nov 2, 2016

[approve ci]

@atsci
Copy link

atsci commented Nov 2, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1039/ for details.

@atsci
Copy link

atsci commented Nov 2, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1146/ for details.

@jrushford
Copy link
Contributor Author

jrushford commented Nov 2, 2016

removed unused variable in Eventsystem.cc and squashed commits.

@atsci
Copy link

atsci commented Nov 2, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1042/ for details.

@jrushford
TS-4957: Make the use of madvise() with MADV_DONTDUMP configurable.
f32ecf8 
(cherry picked from commit 514d3fd)

Refactored to resolve conflicts due to dependent  changes from TS-4156
which cannot be backported to 6.2.x

Conflicts
  iocore/eventsystem/Eventsystem.cc
@atsci
Copy link

atsci commented Nov 2, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1149/ for details.

@atsci
Copy link

atsci commented Nov 2, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1150/ for details.

@atsci
Copy link

atsci commented Nov 2, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1043/ for details.

@PSUdaemon PSUdaemon merged commit ba12827 into apache:6.2.x Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@PSUdaemon PSUdaemon

Labels

Backport Marked for backport for an LTS patch release

Projects

None yet

Milestone

6.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@jrushford @atsci @zwoop @PSUdaemon