Add a dir-entry setting to volumes.config#11838
Merged
Merged
Conversation
9c347c6 to
2846cae
Compare
bryancall
previously approved these changes
Nov 4, 2024
bryancall
approved these changes
Nov 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea / purpose of this is to allow for creating a volume which has a different configuration for the number of directory entries. The use case would be in a mixed environment where you have a mix of very large and very small objects, and don't want to waste a lot of memory for unused directory entries.
Example use:
And then assign volume5 to one or many hosts / domains via hosting.config.
Before using avg_obj_size, we'd get the same number of directories per volume:
after enabling the new configuration on volume5: