Fix setting TLS groups with BoringSSL#11840
Merged
Merged
Conversation
Contributor
Author
|
The For 9.2.x branch, I'll open another PR. |
bneradt
approved these changes
Nov 15, 2024
Contributor
|
Cherry-picked to v10.0.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Dec 4, 2024
* Fix setting TLS groups with BoringSSL * Get rid of #ifdef for old openssl (cherry picked from commit a860656)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that
SSLMultiCertConfigLoader::_set_curvesfunction is not working as expected with BoringSSL. Because this check doesn't work with BoringSSL, because it's defined as a function instead of macro.