TS-4938: Avoid crashes due to NULL vc dereferences.#1232
Merged
PSUdaemon merged 1 commit intoapache:6.2.xfrom Nov 28, 2016
Merged
TS-4938: Avoid crashes due to NULL vc dereferences.#1232PSUdaemon merged 1 commit intoapache:6.2.xfrom
PSUdaemon merged 1 commit intoapache:6.2.xfrom
Conversation
One more null check. Remove server_session null checks. And address James' comments. clang-format (cherry picked from commit 784e7cc) Conflicts: proxy/http/HttpSM.cc proxy/http/HttpServerSession.h
Contributor
|
[approve ci] @shinrich can you give this a look over and check to see if you think it looks ok as a backport? Thanks. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1221/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1114/ for details. |
shinrich
reviewed
Nov 28, 2016
| { | ||
| bool inbound_transparent_p = s->state_machine->ua_session->get_netvc()->get_is_transparent(); | ||
| NetVConnection *vc = s->state_machine->ua_session->get_netvc(); | ||
| bool inbound_transparent_p = vc->get_is_transparent(); |
Member
There was a problem hiding this comment.
This change isn't going to protect from a NULL vc dereference. I just double checked through and it is the change that was made on the master branch, so the backport is consistent.
Member
|
Looks good to me. One minor comment, but it was an issue with the original change. So I think the backport is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially this could fix TS-5046 SEGV HttpSM::tunnel_handler_server(int event, HttpTunnelProducer *p)
cherry picked from commit 784e7cc
Conflicts:
proxy/http/HttpSM.cc
proxy/http/HttpServerSession.h