TS-5085 posix_fadvise is incorrectly used in traffic_logcat#1254
Merged
shinrich merged 1 commit intoapache:masterfrom Jan 4, 2017
Merged
TS-5085 posix_fadvise is incorrectly used in traffic_logcat#1254shinrich merged 1 commit intoapache:masterfrom
posix_fadvise is incorrectly used in traffic_logcat#1254shinrich merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
[approve ci] |
danobi
commented
Dec 7, 2016
| } | ||
| // Now that we're done reading a potentially large log file, we can tell the kernel that it's OK to evict | ||
| // the associated log file pages from cache | ||
| posix_fadvise(in_fd, 0, 0, POSIX_FADV_DONTNEED); |
Member
Author
There was a problem hiding this comment.
Oops, I forgot to wrap this call in #if's. Will fix soon.
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1255/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1150/ for details. |
Member
|
Looks good to me. Can you squash? |
`traffic_logcat` was not using `posix_fadvise` correctly. This patch corrects the original poor usage as well as adds some more `posix_fadvise` calls that should help with performance.
Member
Author
|
@shinrich Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
traffic_logcatwas not usingposix_fadvisecorrectly. Thispatch corrects the original poor usage as well as adds some more
posix_fadvisecalls that should help with performance.