geoip - replace pcre with Regex #12578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancall
approved these changes
Oct 21, 2025
Contributor
bryancall
left a comment
bryancall
left a comment
There was a problem hiding this comment.
LGTM. Clean migration from PCRE to Regex class. Properly handles memory management with destructors to clean up dynamically allocated Regex and Acl objects. The use of std::string_view for non-null-terminated strings is correct and follows the established pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copilot suggested about some mem leaks. (despite no
pcre_freefound 🔥 )