TS-5103: replace ua_raw_buffer_reader with ua_buffer_reader#1271
Merged
shinrich merged 1 commit intoapache:masterfrom Jan 6, 2017
Merged
TS-5103: replace ua_raw_buffer_reader with ua_buffer_reader#1271shinrich merged 1 commit intoapache:masterfrom
shinrich merged 1 commit intoapache:masterfrom
Conversation
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1275/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/1170/ for details. |
Member
|
Yes, this looks like the correct change to me. We should be checking that there is more data on the ua_buffer_reader. In this case, there should always be data on the ua_raw_buffer_reader, so we will be incorrectly blind tunneling GET requests without keep alive enabled. (I think). We only want to flip to tunnel mode if there is data after the already parsed header which would be reflected by the ua_buffer_reader. |
shinrich
approved these changes
Jan 4, 2017
Member
shinrich
left a comment
shinrich
left a comment
There was a problem hiding this comment.
See my previous comment (figuring out this review flow..) Looks like a good fix to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.