Automatic caching of parsed STRING config values #12735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bneradt
commented
Dec 5, 2025
src/api/InkAPI.cc
Outdated
Comment on lines
7539
to
7540
| auto &parsed = ParsedConfigCache::lookup(conf, std::string_view(value, length)); | ||
| s->t_state.my_txn_conf().negative_caching_list = parsed.status_code_list; |
Contributor
Author
There was a problem hiding this comment.
These ParsedConfigCache::lookup are the high level view of where the value of this patch happens. Instead of calling the conversion logic for each of these "complex" strings (like the negative caching status list, in this example) every transaction, this parsed value retrieval is called through an interface that caches the results so that the compution is only done once.
This introduces ParsedConfigCache in HttpConfig to automatically cache parsed results for STRING configs that require expensive parsing. When TSHttpTxnConfigStringSet() is called for configs like negative_caching_list, insert_forwarded, server_session_sharing.match, negative_revalidating_list, or host_res_data (ip_resolve), the parsing now happens once per unique value and is cached for subsequent calls. This optimization is transparent to plugins - they call TSHttpTxnConfigStringSet() as usual and automatically benefit from the caching. Fixes: apache#12292
bneradt
force-pushed
the
config_conversion_caching
branch
from
4df9b0c to
6beaff4
Compare
masaori335
reviewed
Dec 7, 2025
masaori335
reviewed
Dec 7, 2025
masaori335
reviewed
Dec 7, 2025
masaori335
approved these changes
Dec 9, 2025
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
This seems better than other approaches, because we don't need to change TS APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces ParsedConfigCache in HttpConfig to automatically cache parsed results for STRING configs that require expensive parsing. When TSHttpTxnConfigStringSet() is called for configs like negative_caching_list, insert_forwarded, server_session_sharing.match, negative_revalidating_list, or host_res_data (ip_resolve), the parsing now happens once per unique value and is cached for subsequent calls. This optimization is transparent to plugins - they call TSHttpTxnConfigStringSet() as usual and automatically benefit from the caching.
Fixes: #12292