Skip to content

Add support for PP2_SUBTYPE_SSL_GROUP#12921

Open
maskit wants to merge 1 commit intoapache:masterfrom
maskit:pp_tls_group
Open

Add support for PP2_SUBTYPE_SSL_GROUP#12921
maskit wants to merge 1 commit intoapache:masterfrom
maskit:pp_tls_group

Conversation

@maskit
Copy link
Member

@maskit maskit commented Feb 27, 2026

No description provided.

@maskit maskit added this to the 11.0.0 milestone Feb 27, 2026
@maskit maskit self-assigned this Feb 27, 2026
@maskit
Copy link
Member Author

maskit commented Feb 27, 2026

[approve ci centos]

2 similar comments
@maskit
Copy link
Member Author

maskit commented Feb 27, 2026

[approve ci centos]

@maskit
Copy link
Member Author

maskit commented Feb 27, 2026

[approve ci centos]

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds end-to-end support for the PROXY Protocol v2 TLS sub-TLV PP2_SUBTYPE_SSL_GROUP so that ATS can parse it, expose it via ProxyProtocol, and log it as a first-class log field.

Changes:

  • Add PP2_SUBTYPE_SSL_GROUP constant and ProxyProtocol::get_tlv_ssl_group() accessor.
  • Add a new logging marshal function and register a new log field (proxy_protocol_tls_group / pptg).
  • Extend the Proxy Protocol v2 parser unit test and update logging field documentation.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/proxy/logging/LogAccess.cc Implements marshaling of the TLS group string from PROXY Protocol context for logging.
include/proxy/logging/LogAccess.h Declares the new marshaling method for the logging subsystem.
src/proxy/logging/Log.cc Registers the new log field proxy_protocol_tls_group with symbol pptg.
include/iocore/net/ProxyProtocol.h Defines PP2_SUBTYPE_SSL_GROUP and declares the new accessor.
src/iocore/net/ProxyProtocol.cc Implements get_tlv_ssl_group() via existing SSL sub-TLV parsing logic.
src/iocore/net/unit_tests/test_ProxyProtocol.cc Updates v2 TLV test fixture lengths and validates parsing of the new SSL group subtype.
doc/admin-guide/logging/formatting.en.rst Documents the new pptg logging field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants