Add AuTest for connect_attempts rr_retries and max_retries

[masaori335]

Covers combination of proxy.config.http.connect_attempts_rr_retries and proxy.config.http.connect_attempts_max_retries.

The connect_attempts_max_retries_down_server will be covered by #12922

[Copilot]

Pull request overview

Adds new AuTest coverage for origin connect-attempt retry behaviors (round-robin retries vs max retries) and extends the ATS replay test harness to support DNS record injection and error.log validation via replay YAML.

Changes:

• Added three new Proxy Verifier replay scenarios covering proxy.config.http.connect_attempts_rr_retries and proxy.config.http.connect_attempts_max_retries.
• Added new dns/connect_attempts.test.py to run the new replay tests and gold files for error.log expectations.
• Extended tests/gold_tests/autest-site/ats_replay.test.ext to support DNS records injection and error_log validation (including gold-file based validation).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
tests/gold_tests/dns/replay/connect_attempts_rr_retries.replay.yaml	New replay scenario for round-robin retry behavior and down-server cache behavior.
tests/gold_tests/dns/replay/connect_attempts_rr_no_retry.replay.yaml	New replay scenario covering baseline behavior with no retries.
tests/gold_tests/dns/replay/connect_attempts_rr_max_retries.replay.yaml	New replay scenario covering connect_attempts_max_retries behavior.
tests/gold_tests/dns/gold/connect_attempts_rr_retries_error_log.gold	Expected error.log output for rr-retries scenario.
tests/gold_tests/dns/gold/connect_attempts_rr_no_error_log.gold	Expected error.log output for no-retry scenario.
tests/gold_tests/dns/gold/connect_attempts_rr_max_retries_error_log.gold	Expected error.log output for max-retries scenario.
tests/gold_tests/dns/connect_attempts.test.py	Test driver that runs the three new replay tests.
tests/gold_tests/autest-site/ats_replay.test.ext	Adds error_log validation support and DNS records wiring for replay-based tests.

[Copilot]

In ATSReplayTest, the guard if log_validation != None and log_validation['error_log'] != None: can raise a KeyError when autest.ats.log_validation exists but does not define error_log (e.g. many existing replay tests only use traffic_out / diags_log). Please switch to a safe lookup (e.g. error_log_cfg = (log_validation or {}).get('error_log')) and check that value instead.

[Copilot]

The header comment says caching is enabled, but this replay config explicitly sets process_config.enable_cache: false. Please update or remove the comment so it matches the test configuration.

Suggested change

	# This replay file assumes that caching is enabled.
	# This replay file runs with caching disabled.

[Copilot]

Spelling: "immidiately" should be "immediately" in this comment (and consider rewording to a full sentence for clarity).

Suggested change

	# request expected hit down_server cache and immidiately get 500
	# This request is expected to hit the down_server cache and immediately receive a 500 response.

[Copilot]

The header comment says caching is enabled, but this replay config explicitly sets process_config.enable_cache: false. Please update or remove the comment so it matches the test configuration.

Suggested change

	# This replay file assumes that caching is enabled.
	# This replay file runs with ATS caching disabled.

[Copilot]

Spelling: "immidiately" should be "immediately" in this comment (and consider rewording to a full sentence for clarity).

Suggested change

	# request expected hit down_server cache and immidiately get 500
	# The request is expected to hit the down_server cache and immediately receive a 500 response.

[Copilot]

The header comment says caching is enabled, but this replay config explicitly sets process_config.enable_cache: false. Please update or remove the comment so it matches the test configuration.

Suggested change

	# This replay file assumes that caching is enabled.
	# This replay file assumes that caching is disabled.

[Copilot]

Spelling: "immidiately" should be "immediately" in this comment (and consider rewording to a full sentence for clarity).

Suggested change

	# request expected hit down_server cache and immidiately get 500
	# The request is expected to hit the down_server cache and immediately receive a 500 response.

[masaori335]

Somehow, the connect_attempts_rr_max_retries test is keep trying 0.0.0.1 even after it's marked "down" instead of round robin to 0.0.0.2 in this env.

20260302.01h50m26s CONNECT: attempt fail [CONNECTION_ERROR] to 0.0.0.1:62299 for host='example.com' connection_result=ETIMEDOUT [110] error=ETIMEDOUT [110] retry_attempts=0 url='http://backend.example.com:62299/path/'
20260302.01h50m28s CONNECT: attempt fail [CONNECTION_ERROR] to 0.0.0.1:62299 for host='example.com' connection_result=ETIMEDOUT [110] error=ETIMEDOUT [110] retry_attempts=1 url='http://backend.example.com:62299/path/'
20260302.01h50m30s CONNECT: attempt fail [CONNECTION_ERROR] to 0.0.0.1:62299 for host='example.com' connection_result=ETIMEDOUT [110] error=ETIMEDOUT [110] retry_attempts=2 url='http://backend.example.com:62299/path/'
20260302.01h50m30s CONNECT : ETIMEDOUT [110] connecting to 0.0.0.1:62299 for host='example.com' url='http://backend.example.com:62299/path/' fail_count='1' marking down
20260302.01h50m31s CONNECT: attempt fail [CONNECTION_ERROR] to 0.0.0.1:62299 for host='example.com' connection_result=ETIMEDOUT [110] error=ETIMEDOUT [110] retry_attempts=0 url='http://backend.example.com:62299/path/'
20260302.01h50m33s CONNECT: attempt fail [CONNECTION_ERROR] to 0.0.0.1:62299 for host='example.com' connection_result=ETIMEDOUT [110] error=ETIMEDOUT [110] retry_attempts=1 url='http://backend.example.com:62299/path/'
20260302.01h50m34s CONNECT: attempt fail [CONNECTION_ERROR] to 0.0.0.1:62299 for host='example.com' connection_result=ETIMEDOUT [110] error=ETIMEDOUT [110] retry_attempts=2 url='http://backend.example.com:62299/path/'