Skip to content

Fix memory leaks in plugins #13028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bryancall wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix memory leaks in plugins #13028

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2d2f64
Fix memory leak in client_context_dump plugin
bryancall Mar 23, 2026
eb7e9fd
Fix memory leak in ConfigCache destructor
bryancall Mar 23, 2026
b1a0a78
Fix memory leak of HCFileInfo linked list in healthchecks
bryancall Mar 23, 2026
c1fa557
Fix memory leak of log_info.filename in stale_response
bryancall Mar 23, 2026
c5e336e
Revert healthchecks shutdown handler — races with hc_thread The shutd…
bryancall Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/plugins/c-api/client_context_dump/client_context_dump.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,7 @@ CB_context_dump(TSCont, TSEvent, void *edata)
for (int i = 0; i < count; i += 2) {
dump_context(results[i], results[i + 1]);
}
free(results);
}
}
TSTextLogObjectFlush(context_dump_log);
Expand Down
5 changes: 5 additions & 0 deletions plugins/experimental/stale_response/stale_response.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@

#pragma once

#include <cstdlib>

#include "ts/apidefs.h"
#include "ts_wrap.h"
#include "ts/ts.h"
Expand Down Expand Up @@ -63,6 +65,9 @@ struct ConfigInfo {
if (this->body_data_mutex) {
TSMutexDestroy(this->body_data_mutex);
}
if (this->log_info.filename != PLUGIN_TAG) {
free(const_cast<char *>(this->log_info.filename));
}
}
UintBodyMap *body_data = nullptr;
TSMutex body_data_mutex;
Expand Down
9 changes: 9 additions & 0 deletions plugins/origin_server_auth/origin_server_auth.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ class S3Config;
class ConfigCache
{
public:
~ConfigCache();

S3Config *get(const char *fname);

private:
Expand Down Expand Up @@ -601,6 +603,13 @@ class S3Config
int _invalid_file_count = 0;
};

ConfigCache::~ConfigCache()
{
for (auto &[key, data] : _cache) {
delete data.config.load();
}
}

bool
S3Config::parse_config(const std::string &config_fname)
{
Expand Down