Open
Conversation
Move ATS core off the remaining remap-only parsing path and route remap.config loading through the shared src/config remap parser. This lets traffic_ctl and traffic_server use the same conversion logic while leaving only runtime regex-mapping helpers in the remap loader. This builds off of the work to support remap.yaml here: apache#12997
bneradt
force-pushed
the
refactor-remapyaml-parsing
branch
from
5c17ee4 to
22db9c6
Compare
masaori335
reviewed
Apr 3, 2026
|
|
||
| constexpr swoc::Errata::Severity ERRATA_NOTE_SEV{static_cast<swoc::Errata::severity_type>(DL_Note)}; | ||
| constexpr swoc::Errata::Severity ERRATA_ERROR_SEV{static_cast<swoc::Errata::severity_type>(DL_Error)}; | ||
|
|
Contributor
There was a problem hiding this comment.
I prefer YAML key names definition in the beginning.
masaori335
reviewed
Apr 3, 2026
| namespace config | ||
| { | ||
|
|
||
| using RemapConfig = YAML::Node; |
Contributor
There was a problem hiding this comment.
Hmm, can we define some struct describes remap.yaml node tree? It'll help us understanding type of node - int, string, list, map.
masaori335
reviewed
Apr 3, 2026
| DbgCtl dbg_ctl_url_rewrite{"url_rewrite"}; | ||
|
|
||
| swoc::Errata | ||
| parse_yaml_volume(const YAML::Node &node, url_mapping *url_mapping) |
Contributor
There was a problem hiding this comment.
I feel these parsers in this file should moved to config/remap.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ATS core off the remaining remap-only parsing path and route remap.config loading through the shared src/config remap parser. This lets traffic_ctl and traffic_server use the same conversion logic while leaving only runtime regex-mapping helpers in the remap loader.
This builds off of the work to support remap.yaml here: #12997