proxy-request.expect: absent in PV replays#13054
Merged
bneradt merged 1 commit intoapache:masterfrom Apr 3, 2026
Merged
Conversation
bneradt
force-pushed
the
codex/pv-expect-absent-replays
branch
from
733adc6 to
5ec4d25
Compare
bneradt
changed the title
Proxy Verifier v3.1.2 can now assert that ATS does not send an upstream request. Update replay transactions that serve from cache or otherwise respond locally to use proxy-request.expect: absent. This makes the no-origin cases explicit across the gold tests and turns the old trap server responses into a direct expectation. Leave the cache-control-basic miss transaction alone because it must still go upstream to prime the cache, and fix one stale HEAD/GET cache comment so the replay text matches the origin behavior.
bneradt
force-pushed
the
codex/pv-expect-absent-replays
branch
from
9e1110e to
8ec503d
Compare
masaori335
approved these changes
Apr 3, 2026
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
Nice! This clarify behavior of ATS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxy Verifier v3.1.2 can now verify that ATS does not send an upstream
request to the origin. Update replay transactions that serve from cache
or otherwise respond locally to use proxy-request.expect: absent.
This makes the no-origin cases explicit across the autests and turns the
old trap server responses into a direct expectation. It also fixes one
stale comment in the HEAD/GET cache replay so the test text matches the
origin behavior.