Exclude http_load sources from RAT#13067
Closed
bneradt wants to merge 2 commits into
Closed
Conversation
This excludes the third-party http_load sources from RAT checks. These files carry their own upstream license text rather than ASF headers, so checking them as Apache-licensed sources causes a false failure. This keeps the RAT target consistent across environments and avoids local failures on http_load.c.
maskit
requested changes
Apr 7, 2026
Member
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
Can we narrow the scope to tools/http_load/. We may use same file names in another directory.
This updates the RAT target to scan a filtered source tree instead of excluding basenames globally. The filtered tree drops only the third-party tools/http_load sources that carry their own upstream license text. This keeps RAT from masking unrelated files that may reuse the same names elsewhere in the tree.
Member
|
[approve ci autest 2] |
Member
|
(Seems like autest sigusr2 is still unstable...) I thought the change is just prepending the path like: And now I see many entries that only check filenames without the paths. Did we actually chose to have just filename so that we can move files into another directory easily? |
Contributor
Author
|
I'm going to resolve this by updating from rat 0.13 to 0.17 which supports glob-like paths, making addressing this easier. See: #13071 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This excludes the third-party http_load sources from RAT checks.
These files carry their own upstream license text rather than ASF
headers, so checking them as Apache-licensed sources causes a false
failure.
This keeps the RAT target consistent across environments and avoids
local failures on http_load.c.