Cleanup set_connect_fail debug log#13091
Merged
masaori335 merged 3 commits intoapache:masterfrom Apr 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a debug log in HttpTransact::State::set_connect_fail() to print errno values in a more readable form (symbolic name/message) instead of raw integers.
Changes:
- Replaces a
Dbg()integer-based message withswoc::bwprint+swoc::bwf::Errnoformatting. - Adds an explicit
_dbg_ctl.on()guard before building the formatted message.
bneradt
approved these changes
Apr 21, 2026
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Apr 23, 2026
* Cleanup set_connect_fail debug log * Fix args * Include swoc header explicitly (cherry picked from commit 7e9aa23)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print name of
errnoto clarify.