Guard HTTP/3 test targets with BUILD_TESTING#13094
Merged
Merged
Conversation
bneradt
added
CMake
Guard add_catch2_test for h3 with BUILD_TESTING. Otherwise -DBUILD_TESTING=off fails when HTTP/3 builds are enabled.
bneradt
force-pushed
the
fix-h3-non-ut-builds
branch
from
b47baaa to
09847aa
Compare
maskit
approved these changes
Apr 17, 2026
Contributor
|
Cherry-picked to 10.2.x |
cmcfarlen
pushed a commit
that referenced
this pull request
Apr 21, 2026
Guard add_catch2_test for h3 with BUILD_TESTING. Otherwise -DBUILD_TESTING=off fails when HTTP/3 builds are enabled. (cherry picked from commit 5b7ab92)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard add_catch2_test for h3 with BUILD_TESTING. Otherwise
-DBUILD_TESTING=off fails when HTTP/3 builds are enabled.