Guard txn_box stack allocations#13128
Closed
bneradt wants to merge 1 commit into
Closed
Conversation
Large tuple features and Host field rewrites can flow through txn_box from request-controlled input. Several paths used alloca with sizes derived from those values, which could consume a large fraction of the ATS thread stack or overflow it outright. This bounds the temporary filter tuple array by a byte budget and aligns Host field rewrite buffers with the core host-name limit. Oversized filter input now returns an error, while oversized Host rewrites leave the existing Host field unchanged instead of allocating a large stack buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large tuple features and Host field rewrites can flow through txn_box from
request-controlled input. Several paths used alloca with sizes derived from
those values, which could consume a large fraction of the ATS thread stack or
overflow it outright.
This bounds the temporary filter tuple array by a byte budget and aligns Host
field rewrite buffers with the core host-name limit. Oversized filter input now
returns an error, while oversized Host rewrites leave the existing Host field
unchanged instead of allocating a large stack buffer.