nexthop health status don't overflow fail count#13164
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request prevents HostRecord::failCount (a std::atomic<uint32_t>) from overflowing/wrapping when repeatedly marking a next hop down, by saturating the counter at UINT32_MAX. This aligns with ATS’s parent fail threshold behavior (default 10) while making the failure accounting robust under extreme conditions.
Changes:
- Saturate
failCountincrements inNextHopHealthStatus::markNextHop()to avoiduint32_toverflow. - Fix log formatting to correctly print the
uint32_tfail count usingPRIu32. - Add a unit test that forces
failCountnearUINT32_MAXand verifies it saturates (does not wrap to 0).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/proxy/http/remap/NextHopHealthStatus.cc |
Adds saturating increment logic for failCount and updates related log format specifiers. |
src/proxy/http/remap/unit-tests/test_NextHopRoundRobin.cc |
Adds a regression test ensuring failCount saturates at UINT32_MAX during repeated markdowns. |
bneradt
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a check to ensure that failcount doesn't overflow uint32.
default ATS configuration is from https://docs.trafficserver.apache.org/en/latest/admin-guide/files/records.yaml.en.html#proxy-config-http-parent-proxy-fail-threshold