proxy.config.dns.search_default_domains: allow 2#13176
Merged
Merged
Conversation
proxy.config.dns.search_default_domains documents mode 2, and the DNS runtime accepts it, but the record validation range rejected the value through config updates. This expands the record validation range to include 2 and adds a records unit test that keeps the documented values accepted while still rejecting values outside the range. Fixes: apache#13175
bneradt
added
Bug
DNS
Records
bneradt
changed the title
zwoop
approved these changes
May 19, 2026
Contributor
Author
|
Backport to 10.1.x required some merge conflicts. I made a separate PR for it: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proxy.config.dns.search_default_domains is implemented for and documents
mode 2, but the record validation range rejected the value, only
allowing values 0 or 1.
This expands the record validation range to allow the user to configure
a 2 for proxy.config.dns.search_default_domains.
Fixes: #13175