Fix txn_box unused find result#13291
Merged
Merged
Conversation
Clang 22 treats the ignored std::unordered_map::find result in the txn_box unit perf test as a warning, and the project builds with warnings promoted to errors. The test therefore fails to compile even though the lookup is intentionally only being timed. This explicitly discards the lookup result in the benchmark lambda and corrects the printed label to describe the lookup operation.
zwoop
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 22 treats the ignored std::unordered_map::find result in the
txn_box unit perf test as a warning, and the project builds with
warnings promoted to errors. The test therefore fails to compile even
though the lookup is intentionally only being timed.
This explicitly discards the lookup result in the benchmark lambda and
corrects the printed label to describe the lookup operation.