Skip to content

Downgrade H2 stream error log#13298

Merged
bneradt merged 1 commit into
apache:masterfrom
bneradt:quiet-h2-stream-error-log
Jun 23, 2026
Merged

Downgrade H2 stream error log#13298
bneradt merged 1 commit into
apache:masterfrom
bneradt:quiet-h2-stream-error-log

Conversation

@bneradt

@bneradt bneradt commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Malformed HTTP/2 parse errors can hit this path during normal
bad-client traffic, and logging each one at ERROR keeps diags noisy.
PR #13059 now emits transaction log entries for these malformed
requests, so operators can diagnose the rejected request without this
default error log noise.

This downgrades the stream creation failure message to the existing
HTTP/2 session debug path. Operators can still enable the http2_cs
debug tag when they need the protocol-level detail.

Malformed HTTP/2 parse errors can hit this path during normal
bad-client traffic, and logging each one at ERROR keeps diags noisy.
PR apache#13059 now emits transaction log entries for these malformed
requests, so operators can diagnose the rejected request without this
default error log noise.

This downgrades the stream creation failure message to the existing
HTTP/2 session debug path. Operators can still enable the http2_cs
debug tag when they need the protocol-level detail.
Copilot AI review requested due to automatic review settings June 18, 2026 23:31
@bneradt bneradt added this to the 11.0.0 milestone Jun 18, 2026
@bneradt bneradt self-assigned this Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bneradt bneradt added HTTP/2 Logging Debug Support for system debugging easy_review No new logic, easy to review. labels Jun 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@bneradt bneradt merged commit b79c0f8 into apache:master Jun 23, 2026
15 checks passed
@bneradt bneradt deleted the quiet-h2-stream-error-log branch June 23, 2026 17:55
bneradt added a commit that referenced this pull request Jun 23, 2026
This reverts commit b79c0f8.

Claude noticed that there are two messages like this, and this is the wrong one. I thought "new_transaction", chosen by Codex, made sense. But we really want the one in Http2ConnectionState::rcv_frame for inbound client errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Debug Support for system debugging easy_review No new logic, easy to review. HTTP/2 Logging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants