MemView: Fix strlen issue for OmniOS.#1491
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Feb 25, 2017
Merged
Conversation
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/freebsd-github/1614/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/linux-github/1509/ for details. |
|
Intel CC build successful! See https://ci.trafficserver.apache.org/job/icc-github/47/ for details. |
|
clang-analyzer build successful! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/179/ for details. |
postwait
approved these changes
Feb 25, 2017
Contributor
postwait
left a comment
postwait
left a comment
There was a problem hiding this comment.
This addresses the build on OmniOS 151014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than put
ink_platform.hin the header file, the constructor usingstrlenwas moved to the implementation file andink_platform.hincluded there. The reason for this it is very important to me to be able to use these classes in plugins and that isn't possible ifink_platform.his a required header.