Conversation
proxy/http/HttpConfig.h
Outdated
|
|
||
| MgmtInt body_factory_response_max_size; | ||
|
|
||
| MgmtByte forward_proxy_ftp_enabled; |
There was a problem hiding this comment.
Can you move this up where other MgmtByte's are? That avoids unnecessary padding of the bytes (as it is above, you would waste at least 3 bytes in the struct).
There was a problem hiding this comment.
I just spoke to our guru and we can easily do this.
| HttpEstablishStaticConfigLongLong(c.synthetic_port, "proxy.config.admin.synthetic_port"); | ||
|
|
||
| // FTP protocol enabled | ||
| HttpEstablishStaticConfigByte(c.forward_proxy_ftp_enabled, "proxy.config.ftp_enabled"); |
There was a problem hiding this comment.
Can we make this overridable as well? That would allow you to turn on /off this feature per remap rule (or via a plugin).
There was a problem hiding this comment.
Is that usable, though? TS is going to dealt with the request header by that point and already committed to HTTP or FTP.
There was a problem hiding this comment.
Do we need to change this? If so, could you provide some more details on what you want us to do.
| @@ -0,0 +1,123 @@ | |||
| ''' | |||
There was a problem hiding this comment.
If at all possible, can you convert this to the new AU test system? @dragon512 can perhaps assist as well.
There was a problem hiding this comment.
Is there documentation for the new AU system?
There was a problem hiding this comment.
for the test engine what I have at the moment is here:
https://bitbucket.org/dragon512/reusable-gold-testing-system/wiki/Home
For stuff extended for the traffic server is here:
https://github.com/apache/trafficserver/blob/master/tests/getting_started.md
I would suggest look at some of the test to get a basic feel of what your test probably will look like.
|
We decided that we need to dedicate some time to these issues and do not anticipate having an update this week as we are busy on other matters. |
|
[approve ci] |
|
You guys still working on this? Since autest is gone, that'll need to be removed or changed to use the new autest. Also, going back to my comment, it'd be nice if proxy.config.ftp_enabled was an overridable configuration (such that you can turn it on per e.g. remap rule). |
|
It looks like we will not be able to work on this for the next few months at least. Can we ignore this request for the time being? Is is easier for me to just close the pull request for the moment and then in the future create a new one? Thank-you. |
Conflicts: proxy/http/HttpConfig.h tests/tools/sessionvalidation/sessionvalidation.py
|
[approve ci] |
|
Closing for the time being. |
5 participants
At the moment TS blocks requests for FTP URLs with an 'Unsupported Protocol' error message. This precludes TS from simply forwarding requests for FTP URLs to an upstream (parent) proxy.
We propose a fix to allow TS to forward FTP URLs to an upstream (parent) proxy; where this proxy supports HTTP/FTP conversion (e.g. Squid) this would enable FTP resources to be retrieved via TS. This change would also allow protocol plugins to be developed that support FTP URLs.
FTP Support would be optionally enabled with a new configuration setting in records.config preserving existing functionality if not present or set to the default value of false.
e.g.
proxy.config.ftp_enabled=1