Skip to content

Changed some of the HTTP/2 enums to enum classes and found a bug#1612

Merged
bryancall merged 1 commit intoapache:masterfrom
bryancall:http2_enum_class
Mar 28, 2017
Merged

Changed some of the HTTP/2 enums to enum classes and found a bug#1612
bryancall merged 1 commit intoapache:masterfrom
bryancall:http2_enum_class

Conversation

@bryancall
Copy link
Copy Markdown
Contributor

@bryancall bryancall commented Mar 27, 2017

found a bug in is_client_state_writeable()

@bryancall bryancall requested review from masaori335 and zwoop March 27, 2017 21:47
@bryancall bryancall self-assigned this Mar 27, 2017
@bryancall bryancall added this to the 7.2.0 milestone Mar 27, 2017
@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/110/

@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/124/

@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/107/

@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1806/

@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1697/

@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/236/

@zwoop zwoop removed this from the 7.2.0 milestone Mar 27, 2017
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Mar 27, 2017

Moved to 7.1.0, I think this is a good patch + good fix!

zwoop
zwoop approved these changes Mar 27, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@zwoop zwoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, looks good ,nice catch on the enum conditional.

@atsci
Copy link
Copy Markdown

atsci commented Mar 27, 2017

clang-analyzer build successful! https://ci.trafficserver.apache.org/job/clang-analyzer-github/368/

@zwoop zwoop added this to the 7.1.0 milestone Mar 27, 2017
@maskit
Copy link
Copy Markdown
Member

maskit commented Mar 27, 2017

@bryancall Looks good to me, but I don't see which part was the bug.

maskit
maskit approved these changes Mar 28, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@maskit maskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I found it. Nice catch!

@bryancall bryancall merged commit b2bddd3 into apache:master Mar 28, 2017
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Mar 29, 2017

Cherry picked to 7.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maskit maskit maskit approved these changes

@zwoop zwoop zwoop approved these changes

@masaori335 masaori335 Awaiting requested review from masaori335

Assignees

@bryancall bryancall

Labels

HTTP/2

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bryancall @atsci @zwoop @maskit