-
Notifications
You must be signed in to change notification settings - Fork 848
Handy tool to decode via header #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
How is this different / better than |
zwoop
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One missing piece: Please add the ASF license blurb to the top of this file (right after the shebang). You can copy it from any of the other perl scripts in the git repository.
Also, it might be better to do e.g.
#!/usr/bin/env perl
for the shebang. Finally, there seems to be a number of empty lines at the bottom of the file, please remove those too :).
|
Once we land this, I'll take care of moving and replacing the existing cmd/traffic_server code. @SolidWallOfCode @bryancall I'd like to get this in for 8.0.0 as well. I think it makes much more sense to have traffic_via as a simple script, that can be included in people working systems, and not necessarily tied to an ATS version / release. If I recall, the C++ version also currently requires the mgmt port for it to function, which the perl script did not. |
|
OK. |
|
Tested and I like the option to take stdin. It should be renamed to traffic_via once the C code is removed. |
|
[approve ci] |
|
@meeramn Please squash the commits. |
|
This is for #3809 |
79e488f to
f99dbeb
Compare
f99dbeb to
f2332a3
Compare
Handy tool developed in perl few years ago to easily decode via header.