Skip to content

Make sure "traffic_ctl config reload" only reloads configs that changed #4122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
duke8253 merged 1 commit into from
Aug 17, 2018
Merged

Make sure "traffic_ctl config reload" only reloads configs that changed #4122

duke8253 merged 1 commit into from
Aug 17, 2018

Conversation

@duke8253
Copy link
Contributor

@duke8253 duke8253 commented Aug 16, 2018 •
edited
Loading

The behavior of command traffic_ctl config reload is broken right now, instead of checking whether the configs actually changed it will try to update it, this commit fixes that problem. The problem was caused by commit 3e88f13

Example output of old behavior:

[Aug 13 23:38:09.982] {0x2abf805e9700} NOTE: updated diags config
[Aug 13 23:38:09.982] {0x2abf805e9700} NOTE: updated diags config
[Aug 13 23:38:09.982] {0x2abf805e9700} NOTE: updated diags config
[Aug 13 23:38:09.982] {0x2abf805e9700} NOTE: updated diags config
[Aug 13 23:38:09.982] {0x2abf805e9700} NOTE: updated diags config
[Aug 13 23:38:09.982] {0x2abf805e9700} NOTE: updated diags config
[Aug 13 23:38:09.988] {0x1a2a2700} NOTE: loading SSL certificate configuration from /home/y/conf/trafficserver/ssl_multicert.config
[Aug 13 23:38:10.028] {0x1a2a2700} NOTE: successfully initialized certinfo for cedexis_sre-perim_com.pem into SSL_CTX: 0x2ac1c7008f40
[Aug 13 23:38:10.030] {0x1a2a2700} NOTE: successfully initialized certinfo for star_edge_tumblr_com.pem into SSL_CTX: 0x2ac1b186ceb0
[Aug 13 23:38:10.033] {0x1a2a2700} NOTE: successfully initialized certinfo for onepush_query_yahoo_com.pem into SSL_CTX: 0x2ac1c2847060
[Aug 13 23:38:10.035] {0x1a2a2700} NOTE: successfully initialized certinfo for vendor_g11n_yahoo_com.pem into SSL_CTX: 0x2ac1bf21ef50
[Aug 13 23:38:10.037] {0x1a2a2700} NOTE: successfully initialized certinfo for s_yimg_com.pem into SSL_CTX: 0x2ac1c3089010
[Aug 13 23:38:10.039] {0x1a2a2700} NOTE: successfully initialized certinfo for zenfs_ssl_cert.pem into SSL_CTX: 0x2ac1cbafa5b0
[Aug 13 23:38:10.041] {0x1a2a2700} NOTE: successfully initialized certinfo for api_gemini_yahoo_com.pem into SSL_CTX: 0x2ac1bc037240
[Aug 13 23:38:10.044] {0x1a2a2700} NOTE: successfully initialized certinfo for sp_analytics_yahoo_com.pem into SSL_CTX: 0x2ac1ca53ffd0
[Aug 13 23:38:10.046] {0x1a2a2700} NOTE: successfully initialized certinfo for us_lrd_yahoo_com.pem into SSL_CTX: 0x2ac1ca541120
[Aug 13 23:38:10.048] {0x1a2a2700} NOTE: successfully initialized certinfo for answers_yahoo_com.pem into SSL_CTX: 0x2ac1bf623020
[Aug 13 23:38:10.050] {0x1a2a2700} NOTE: successfully initialized certinfo for cdn-ycs_vidible_tv.pem into SSL_CTX: 0x2ac1b8078910
[Aug 13 23:38:10.052] {0x1a2a2700} NOTE: successfully initialized certinfo for star_ads_yahoo_com.pem into SSL_CTX: 0x2ac1cab624d0
[Aug 13 23:38:10.054] {0x1a2a2700} NOTE: successfully initialized certinfo for carddav_aol_com.pem into SSL_CTX: 0x2ac1b0826640
[Aug 13 23:38:10.056] {0x1a2a2700} NOTE: successfully initialized certinfo for www_atdn_com.pem into SSL_CTX: 0x2ac1c4590d60
[Aug 13 23:38:10.058] {0x1a2a2700} NOTE: successfully initialized certinfo for www_brightroll_com.pem into SSL_CTX: 0x2ac1cb0833e0
[Aug 13 23:38:10.060] {0x1a2a2700} NOTE: successfully initialized certinfo for mail_aol_com.pem into SSL_CTX: 0x2ac1cb488490
[Aug 13 23:38:10.062] {0x1a2a2700} NOTE: successfully initialized certinfo for transparency_oath_com.pem into SSL_CTX: 0x2ac1f941b290
[Aug 13 23:38:10.064] {0x1a2a2700} NOTE: successfully initialized certinfo for ads_mp_mydas_mobi.pem into SSL_CTX: 0x2ac1feb77680
[Aug 13 23:38:10.065] {0x1a2a2700} NOTE: successfully initialized certinfo for gsdapps_ouroath.pem into SSL_CTX: 0x2ac20b610d60
[Aug 13 23:38:10.067] {0x1a2a2700} NOTE: successfully initialized certinfo for star_help_yahoo_com.pem into SSL_CTX: 0x2ac20afb74e0
[Aug 13 23:38:10.069] {0x1a2a2700} NOTE: successfully initialized certinfo for secure_ace_advertising_com.pem into SSL_CTX: 0x2ac20b0698d0
[Aug 13 23:38:10.071] {0x1a2a2700} NOTE: successfully initialized certinfo for ycpi_ssl_cert.pem into SSL_CTX: 0x2ac1ff13db20
[Aug 13 23:38:10.072] {0x1a2a2700} WARNING: previously indexed '*.answers.yahoo.com' with SSL_CTX 0x44, cannot index it with SSL_CTX #179 now
[Aug 13 23:38:10.073] {0x1a2a2700} WARNING: previously indexed '*.staticflickr.com' with SSL_CTX 0x1f, cannot index it with SSL_CTX #215 now
[Aug 13 23:38:10.073] {0x1a2a2700} WARNING: previously indexed '*.help.yahoo.com' with SSL_CTX 0x9b, cannot index it with SSL_CTX #217 now
[Aug 13 23:38:10.073] {0x1a2a2700} WARNING: previously indexed 'www.tumblr.com' with SSL_CTX 0x17, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.073] {0x1a2a2700} WARNING: previously indexed 'tumblr.com' with SSL_CTX 0x12, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.073] {0x1a2a2700} WARNING: previously indexed 'api.tumblr.com' with SSL_CTX 0x4, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.073] {0x1a2a2700} WARNING: previously indexed '*.global-pop.tumblr.com' with SSL_CTX 0x9, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.073] {0x1a2a2700} NOTE: ssl_multicert.config done reloading!
[Aug 13 23:38:10.073] {0x1a2a2700} NOTE: loading SSL certificate configuration from /home/y/conf/trafficserver/ssl_multicert.config
[Aug 13 23:38:10.075] {0x1a2a2700} NOTE: successfully initialized certinfo for cedexis_sre-perim_com.pem into SSL_CTX: 0x2ac1ff686420
[Aug 13 23:38:10.076] {0x1a2a2700} NOTE: successfully initialized certinfo for star_edge_tumblr_com.pem into SSL_CTX: 0x2ac1fe863130
[Aug 13 23:38:10.078] {0x1a2a2700} NOTE: successfully initialized certinfo for onepush_query_yahoo_com.pem into SSL_CTX: 0x2ac200357cc0
[Aug 13 23:38:10.080] {0x1a2a2700} NOTE: successfully initialized certinfo for vendor_g11n_yahoo_com.pem into SSL_CTX: 0x2ac20055b130
[Aug 13 23:38:10.081] {0x1a2a2700} NOTE: successfully initialized certinfo for s_yimg_com.pem into SSL_CTX: 0x2ac20062fb70
[Aug 13 23:38:10.083] {0x1a2a2700} NOTE: successfully initialized certinfo for zenfs_ssl_cert.pem into SSL_CTX: 0x2ac20036af60
[Aug 13 23:38:10.085] {0x1a2a2700} NOTE: successfully initialized certinfo for api_gemini_yahoo_com.pem into SSL_CTX: 0x2ac200227fd0
[Aug 13 23:38:10.086] {0x1a2a2700} NOTE: successfully initialized certinfo for sp_analytics_yahoo_com.pem into SSL_CTX: 0x2ac1fe7a34b0
[Aug 13 23:38:10.088] {0x1a2a2700} NOTE: successfully initialized certinfo for us_lrd_yahoo_com.pem into SSL_CTX: 0x2ac20c569db0
[Aug 13 23:38:10.089] {0x1a2a2700} NOTE: successfully initialized certinfo for answers_yahoo_com.pem into SSL_CTX: 0x2ac1b8aa9d70
[Aug 13 23:38:10.091] {0x1a2a2700} NOTE: successfully initialized certinfo for cdn-ycs_vidible_tv.pem into SSL_CTX: 0x2ac1be12b520
[Aug 13 23:38:10.093] {0x1a2a2700} NOTE: successfully initialized certinfo for star_ads_yahoo_com.pem into SSL_CTX: 0x2ac1c57a3550
[Aug 13 23:38:10.094] {0x1a2a2700} NOTE: successfully initialized certinfo for carddav_aol_com.pem into SSL_CTX: 0x2ac1c0b78550
[Aug 13 23:38:10.096] {0x1a2a2700} NOTE: successfully initialized certinfo for www_atdn_com.pem into SSL_CTX: 0x2ac1b944c770
[Aug 13 23:38:10.097] {0x1a2a2700} NOTE: successfully initialized certinfo for www_brightroll_com.pem into SSL_CTX: 0x2ac1b093d8e0
[Aug 13 23:38:10.099] {0x1a2a2700} NOTE: successfully initialized certinfo for mail_aol_com.pem into SSL_CTX: 0x2ac1ca549800
[Aug 13 23:38:10.100] {0x1a2a2700} NOTE: successfully initialized certinfo for transparency_oath_com.pem into SSL_CTX: 0x2ac1bcce0ef0
[Aug 13 23:38:10.102] {0x1a2a2700} NOTE: successfully initialized certinfo for ads_mp_mydas_mobi.pem into SSL_CTX: 0x2ac1c24b0480
[Aug 13 23:38:10.103] {0x1a2a2700} NOTE: successfully initialized certinfo for gsdapps_ouroath.pem into SSL_CTX: 0x2ac1b19219b0
[Aug 13 23:38:10.104] {0x1a2a2700} NOTE: successfully initialized certinfo for star_help_yahoo_com.pem into SSL_CTX: 0x2ac1c7dd68d0
[Aug 13 23:38:10.106] {0x1a2a2700} NOTE: successfully initialized certinfo for secure_ace_advertising_com.pem into SSL_CTX: 0x2ac1cb022370
[Aug 13 23:38:10.108] {0x1a2a2700} NOTE: successfully initialized certinfo for ycpi_ssl_cert.pem into SSL_CTX: 0x2ac1f9ec6d10
[Aug 13 23:38:10.109] {0x1a2a2700} WARNING: previously indexed '*.answers.yahoo.com' with SSL_CTX 0x44, cannot index it with SSL_CTX #179 now
[Aug 13 23:38:10.109] {0x1a2a2700} WARNING: previously indexed '*.staticflickr.com' with SSL_CTX 0x1f, cannot index it with SSL_CTX #215 now
[Aug 13 23:38:10.109] {0x1a2a2700} WARNING: previously indexed '*.help.yahoo.com' with SSL_CTX 0x9b, cannot index it with SSL_CTX #217 now
[Aug 13 23:38:10.110] {0x1a2a2700} WARNING: previously indexed 'www.tumblr.com' with SSL_CTX 0x17, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.110] {0x1a2a2700} WARNING: previously indexed 'tumblr.com' with SSL_CTX 0x12, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.110] {0x1a2a2700} WARNING: previously indexed 'api.tumblr.com' with SSL_CTX 0x4, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.110] {0x1a2a2700} WARNING: previously indexed '*.global-pop.tumblr.com' with SSL_CTX 0x9, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:10.110] {0x1a2a2700} NOTE: ssl_multicert.config done reloading!
[Aug 13 23:38:11.015] {0x2abf82b8e700} WARNING: connect_attempts_rr_retries (3) is greater than connect_attempts_max_retries (2), this means requests will never redispatch to another server
[Aug 13 23:38:13.943] {0x1a3a3700} NOTE: remap.config done reloading!
[Aug 13 23:38:13.943] {0x1a3a3700} NOTE: loading SSL certificate configuration from /home/y/conf/trafficserver/ssl_multicert.config
[Aug 13 23:38:13.944] {0x1a3a3700} NOTE: successfully initialized certinfo for cedexis_sre-perim_com.pem into SSL_CTX: 0x2ac1d8839dd0
[Aug 13 23:38:13.944] {0x1a3a3700} NOTE: successfully initialized certinfo for star_edge_tumblr_com.pem into SSL_CTX: 0x2ac231e20790
[Aug 13 23:38:13.945] {0x1a3a3700} NOTE: successfully initialized certinfo for onepush_query_yahoo_com.pem into SSL_CTX: 0x2ac1a9303da0
[Aug 13 23:38:13.945] {0x1a3a3700} NOTE: successfully initialized certinfo for vendor_g11n_yahoo_com.pem into SSL_CTX: 0x2ac2306c8290
[Aug 13 23:38:13.946] {0x1a3a3700} NOTE: successfully initialized certinfo for s_yimg_com.pem into SSL_CTX: 0x2ac1a605fee0
[Aug 13 23:38:13.946] {0x1a3a3700} NOTE: successfully initialized certinfo for zenfs_ssl_cert.pem into SSL_CTX: 0x2ac230567c90
[Aug 13 23:38:13.947] {0x1a3a3700} NOTE: successfully initialized certinfo for api_gemini_yahoo_com.pem into SSL_CTX: 0x2ac233568040
[Aug 13 23:38:13.948] {0x1a3a3700} NOTE: successfully initialized certinfo for sp_analytics_yahoo_com.pem into SSL_CTX: 0x2ac1e2b8b810
[Aug 13 23:38:13.948] {0x1a3a3700} NOTE: successfully initialized certinfo for us_lrd_yahoo_com.pem into SSL_CTX: 0x2ac1dfa52e30
[Aug 13 23:38:13.949] {0x1a3a3700} NOTE: successfully initialized certinfo for answers_yahoo_com.pem into SSL_CTX: 0x2ac2350a0fc0
[Aug 13 23:38:13.949] {0x1a3a3700} NOTE: successfully initialized certinfo for cdn-ycs_vidible_tv.pem into SSL_CTX: 0x2ac1ee024d20
[Aug 13 23:38:13.950] {0x1a3a3700} NOTE: successfully initialized certinfo for star_ads_yahoo_com.pem into SSL_CTX: 0x2ac1ecd52350
[Aug 13 23:38:13.951] {0x1a3a3700} NOTE: successfully initialized certinfo for carddav_aol_com.pem into SSL_CTX: 0x2ac1ab49f0b0
[Aug 13 23:38:13.951] {0x1a3a3700} NOTE: successfully initialized certinfo for www_atdn_com.pem into SSL_CTX: 0x2ac1a8b70540
[Aug 13 23:38:13.952] {0x1a3a3700} NOTE: successfully initialized certinfo for www_brightroll_com.pem into SSL_CTX: 0x2ac1aa4b3e00
[Aug 13 23:38:13.952] {0x1a3a3700} NOTE: successfully initialized certinfo for mail_aol_com.pem into SSL_CTX: 0x2ac21e281920
[Aug 13 23:38:13.953] {0x1a3a3700} NOTE: successfully initialized certinfo for transparency_oath_com.pem into SSL_CTX: 0x2ac1ee023df0
[Aug 13 23:38:13.954] {0x1a3a3700} NOTE: successfully initialized certinfo for ads_mp_mydas_mobi.pem into SSL_CTX: 0x2ac21ae57610
[Aug 13 23:38:13.954] {0x1a3a3700} NOTE: successfully initialized certinfo for gsdapps_ouroath.pem into SSL_CTX: 0x2ac220cc04c0
[Aug 13 23:38:13.955] {0x1a3a3700} NOTE: successfully initialized certinfo for star_help_yahoo_com.pem into SSL_CTX: 0x2ac216831a40
[Aug 13 23:38:13.955] {0x1a3a3700} NOTE: successfully initialized certinfo for secure_ace_advertising_com.pem into SSL_CTX: 0x2ac21c431bb0
[Aug 13 23:38:13.956] {0x1a3a3700} NOTE: successfully initialized certinfo for ycpi_ssl_cert.pem into SSL_CTX: 0x2ac21ab22470
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed '*.answers.yahoo.com' with SSL_CTX 0x44, cannot index it with SSL_CTX #179 now
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed '*.staticflickr.com' with SSL_CTX 0x1f, cannot index it with SSL_CTX #215 now
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed '*.help.yahoo.com' with SSL_CTX 0x9b, cannot index it with SSL_CTX #217 now
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed 'www.tumblr.com' with SSL_CTX 0x17, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed 'tumblr.com' with SSL_CTX 0x12, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed 'api.tumblr.com' with SSL_CTX 0x4, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:13.956] {0x1a3a3700} WARNING: previously indexed '*.global-pop.tumblr.com' with SSL_CTX 0x9, cannot index it with SSL_CTX #226 now
[Aug 13 23:38:13.957] {0x1a3a3700} NOTE: ssl_multicert.config done reloading!
[Aug 13 23:38:17.491] {0x1a2a2700} NOTE: remap.config done reloading!
[Aug 13 23:38:21.316] {0x1a2a2700} NOTE: remap.config done reloading!

@duke8253 duke8253 added this to the 9.0.0 milestone Aug 16, 2018
@duke8253 duke8253 self-assigned this Aug 16, 2018
@duke8253 duke8253 force-pushed the master-config_reload branch from bd4d605 to 39beff8 Compare August 16, 2018 20:18
SolidWallOfCode
SolidWallOfCode reviewed Aug 16, 2018
View reviewed changes
lib/records/P_RecCore.cc Outdated
if ((data_type != RECD_NULL) && (r1->data_type != data_type)) {
err = REC_ERR_FAIL;
} else {
bool rec_set = false;
Copy link
Member

@SolidWallOfCode SolidWallOfCode Aug 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick, but what about "rec_was_updated" or "rec_updated_p"? I think it's clearer.

@SolidWallOfCode
Copy link
Member

SolidWallOfCode commented Aug 16, 2018

Split out the "Ink64" changes, that should be a separate PR.

@duke8253 duke8253 force-pushed the master-config_reload branch from 39beff8 to 2dcd5d8 Compare August 16, 2018 21:22
@duke8253 duke8253 mentioned this pull request Aug 16, 2018
Merged
@shinrich
Copy link
Member

shinrich commented Aug 16, 2018

Yay! This has been causing us a lot of pain as of late. Could you make a note of the commit that caused this problem so there is a history of which versions are impacted?

@duke8253
Copy link
Contributor Author

duke8253 commented Aug 16, 2018

Yep, just updated the comment.

@duke8253 duke8253 merged commit 8fd7ee0 into apache:master Aug 17, 2018
@SolidWallOfCode SolidWallOfCode mentioned this pull request Aug 17, 2018
Merged
@zwoop
Copy link
Contributor

zwoop commented Aug 29, 2018

I'm making a backport PR for 7.1.5.

@bryancall bryancall modified the milestones: 9.0.0, 8.0.0 Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shinrich shinrich shinrich approved these changes

+1 more reviewer

@SolidWallOfCode SolidWallOfCode SolidWallOfCode left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@duke8253 duke8253

Labels

Commands Configuration

Projects

None yet

Milestone

8.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@duke8253 @SolidWallOfCode @shinrich @zwoop @bryancall