TCL: remove tcl depencency from HostLookUp and refresh for C++11 #4346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is the look of new changes I have on that original PR: nqyy@a2a354b |
nqyy
force-pushed
the
hostlookup_update
branch
from
b5a0231 to
303e4db
Compare
ywkaras
reviewed
Oct 4, 2018
| isNot = true; | ||
| } else { | ||
| isNot = false; | ||
| } |
Contributor
There was a problem hiding this comment.
isNot is set to false by default, so why is the else clause needed?
nqyy
force-pushed
the
hostlookup_update
branch
from
505f934 to
70f69f9
Compare
nqyy
force-pushed
the
hostlookup_update
branch
from
8e6fab8 to
c2587f2
Compare
Contributor
Author
|
This is ready to ship @SolidWallOfCode |
SolidWallOfCode
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resurrection of #3989 by @SolidWallOfCode .
Now it uses STL containers.
This is the first step of the attempt to get rid of the whole TCL dependency.