H1outbound - making H1Txn self destroy #6298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2020 16:09
a-canary
force-pushed
the
h1TxnDestructor
branch
from
67d4d91 to
b9c96f1
Compare
Collaborator
Author
|
[approve ci autest] |
maskit
reviewed
Jan 6, 2020
| ssn_id = _proxy_ssn->get_id(); | ||
|
|
||
| if (_proxy_ssn->get_netvc()->get_context() == NET_VCONNECTION_IN) { | ||
| HTTP2_DECREMENT_THREAD_DYN_STAT(HTTP2_STAT_CURRENT_CLIENT_STREAM_COUNT, _thread); |
Member
There was a problem hiding this comment.
Use of destructors sounds great.
This is just an input for following changes. It would be great if we could generalize the destruction process, and put the code into ProxyTransaction's destructor and the details like this line into subclasses. This is the reason I was talking about decrement_txn_stat on a previous PR.
Member
|
I'm not sure if this is really possible, but if we are going to delete transaction object this way (self destroy), it may be better to make the destructors private (or protected) members. |
-SsnTrace & TxnTrace output for destructor debbuging
Collaborator
Author
|
[approve ci autest] |
1 similar comment
Contributor
|
[approve ci autest] |
Collaborator
Author
|
this has been moved to h1outbound feature branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring H1 code to use destructors on transactions.