Fix g++ 10 compile errors. #6731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancall
reviewed
May 2, 2020
maskit
reviewed
May 4, 2020
| int cleanup(int event, Event *e); | ||
|
|
||
| PinnedDocTable() : Continuation(new_ProxyMutex()) { memset(bucket, 0, sizeof(Queue<PinnedDocEntry>) * PINNED_DOC_TABLE_SIZE); } | ||
| PinnedDocTable() : Continuation(new_ProxyMutex()) { ink_zero(bucket); } |
Member
There was a problem hiding this comment.
Do we need this initialization? Queue's constructor should be called as long as this constructor is called.
maskit
reviewed
May 4, 2020
| num_consumers = 0; | ||
| memset(consumers, 0, sizeof(consumers)); | ||
| memset(producers, 0, sizeof(producers)); | ||
| ink_zero(consumers); |
Member
There was a problem hiding this comment.
I don't think this is a right way to solve the problem. I'd use placement new for each item.
Member
Author
|
@maskit I understand your points, but I think those should be separate PRs. For this one, I tried to minimize changes. Unfortunately I had to do some non-trivial reworking in |
SolidWallOfCode
force-pushed
the
gcc-10-phase-1
branch
from
ca2f217 to
fd32f69
Compare
Contributor
|
[approve ci autest] |
bryancall
approved these changes
May 4, 2020
Contributor
|
Cherry-picked to v9.0.x branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #6716.
Two commits.
traffic_viato usestring_view, which fixes an error which would otherwise be more painful to deal with.