Fix a crash on TLS resumption #6861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinrich
approved these changes
Jun 8, 2020
Member
|
I'll give this change a try. |
Member
|
Verified it addressed the issue. Will kick autest again in the hopes that the compress failure was transient. If not will try to get that test running locally. |
Member
|
[approve ci autest] |
2 similar comments
Member
|
[approve ci autest] |
Member
|
[approve ci autest] |
Contributor
|
Cherry-picked to v9.0.x branch. I assume we don't need this for 8.1.x ? |
Member
Author
|
You're right. We don't need this for 8.1.x as long as we don't backport #6736. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for the crash on TLS resumption.
The crash seems to be caused by a small change made on ##6736. On the PR, I added
this->_setSSLCurveNID(SSLGetCurveNID(ssl));after a call for_setSSLSessionCacheHitfor consistency, but I realized it doesn't make sense in_getSessionInformation.So I removed the line and added a code similar to
fetch_ssl_curve, which was removed on #6736.I couldn't reproduce the crash by myself and CI tests don't catch the crash somehow, so please ran this locally if you can reproduce the crash.