TS-4537 Add erase method to PriorityQueue
#708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksontj
added a commit
to jacksontj/trafficserver
that referenced
this pull request
Jun 14, 2016
Contributor
|
Ping @masaori335 |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/158/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/263/ for details. |
lib/ts/PriorityQueue.h
Outdated
| } | ||
|
|
||
| _v.remove_index(entry->index); | ||
|
|
Contributor
There was a problem hiding this comment.
IMO, we can avoid rewriting all of the indexes because this is Binary Heap.
How about this like what we're doing in PriorityQueue<T, Comp>::pop() ?
_v[entry->index] = _v[_v.length() - 1];
_v.pop();
_bubble_down(entry->index);
Contributor
|
Looks good. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/175/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/283/ for details. |
ogoodman
pushed a commit
to ogoodman/trafficserver
that referenced
this pull request
Aug 20, 2016
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Nov 4, 2016
This closes apache#708 (cherry picked from commit 78850a8) Conflicts: lib/ts/test_PriorityQueue.cc
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* Build with quiche on el7 as well * Unlimit BoringSSL version * Fix * Update version number * Revert changes for CMakeLists * Fix indent * Fix typo * Update quiche version * Use --nobest option * Fix typo * Use setopt instead of nobest * Try not to use super old versions * Try a different order * setopt * Don't install boringssl explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.