Skip to content

Conversation

@duke8253
Copy link
Contributor

@duke8253 duke8253 commented Feb 8, 2021

Testing to see whether this helps with memory allocation lock contention.

@duke8253 duke8253 added this to the 10.0.0 milestone Feb 8, 2021
@duke8253 duke8253 self-assigned this Feb 8, 2021
@duke8253 duke8253 requested a review from bryancall February 8, 2021 20:57
@duke8253 duke8253 force-pushed the master-jemalloc branch 7 times, most recently from 8f046ab to be989be Compare February 9, 2021 22:01
@bryancall
Copy link
Contributor

I will benchmark it.

@duke8253
Copy link
Contributor Author

[approve ci autest]

1 similar comment
@bneradt
Copy link
Contributor

bneradt commented Feb 16, 2021

[approve ci autest]

@bryancall
Copy link
Contributor

bryancall commented Mar 26, 2021

These are benchmarks on a 128 core AMD Epyc server running traffic_server with -F and -f with no logging, since there are known performance issues with logging.

Screen Shot 2021-03-29 at 11 55 38 AM

@duke8253 duke8253 removed the WIP label Jun 15, 2021
@bryancall bryancall added the Bug label Jun 25, 2021
@bryancall
Copy link
Contributor

I will review it.

@bryancall
Copy link
Contributor

Copy link
Contributor

@bryancall bryancall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be able to get better performance using thread_local. In some benchmarks I did it was around 180x faster than using unordered_map with a shared_mutex.

Copy link
Contributor

@masaori335 masaori335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

@zwoop
Copy link
Contributor

zwoop commented Aug 31, 2021

Cherry-picked to v9.1.x branch.

@zwoop zwoop removed this from the 10.0.0 milestone Aug 31, 2021
@zwoop zwoop added this to the 9.1.1 milestone Aug 31, 2021
zwoop pushed a commit that referenced this pull request Aug 31, 2021
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request Mar 7, 2022
* asf/master: (763 commits)
  rate_limit: Add a global hook to rate limit concurrent connections based on SNI (apache#8021)
  Fix uri_signing unit test for out of source builds (apache#8040)
  tests: Add conditions for BoringSSL and OpenSSL (apache#8045)
  change debug tags and make sure sni is printed on certain logs (apache#7673)
  Doc build in CI: build English docs with -W (apache#8039)
  When loading async SSL configuration file fails, log SSL error (apache#8036)
  Doc build: treat warnings as errors only by default (apache#8038)
  For test async_engine, export all symbols (apache#8037)
  Fix the server cert reload (apache#8030)
  Treat Sphinx doc build warnings as errors. (apache#8033)
  Stablize trace curl test in good_request_after_bad (apache#8032)
  Doc: Update documentation to build cleanly in Sphinx 3. Require Sphinx 3 or better. (apache#7978)
  Docs: Fix pre-formatting for ratelimit plugin (apache#7986)
  Make it slightly harder to dump private keys to logs (apache#8029)
  tls_bad_alpn: Add an openssl version skip check (apache#8026)
  per thread jemalloc arena for MADV_DONTDUMP (apache#7501)
  Adds a new rm-destination, this lets you specify either QUERY or PATH, and be able to drop them from the incoming request (apache#8025)
  Fix HPACK eviction iterator manipulation (apache#8004)
  Do not invalidate cached resources upon error responses to unsafe methods (apache#7999)
  Cleanup SSLUtils (apache#8007)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants