Skip to content

Propagate proxy.config.net.sock_option_flag_in to accepted connections#7916

Closed
randall wants to merge 1 commit intoapache:masterfrom
randall:propagate_sock_opts
Closed

Propagate proxy.config.net.sock_option_flag_in to accepted connections#7916
randall wants to merge 1 commit intoapache:masterfrom
randall:propagate_sock_opts

Conversation

@randall
Copy link
Contributor

@randall randall commented Jun 3, 2021

No description provided.

@randall randall added this to the 10.0.0 milestone Jun 3, 2021
@randall randall self-assigned this Jun 3, 2021
@randall randall requested a review from bryancall as a code owner June 3, 2021 03:21
@bryancall
Copy link
Contributor

[approve ci]

@bryancall bryancall removed this from the 10.0.0 milestone Jun 25, 2021
@randall
Copy link
Contributor Author

randall commented Jun 25, 2021

This breaks the regression tests. It comes down to SO_LINGER being set/propagated during the tests.

I think, without this change, setting DSCP via header_rewrite (aka TSHttpTxnClientPacketDscpSet) will be broken due to e65cf23 (which requires PACKET_TOS to be configured in proxy.config.net.sock_option_flag_in). Without the propagation, the bit mask check will fail.

@randall randall closed this Jun 28, 2021
@randall
Copy link
Contributor Author

randall commented Apr 1, 2022

This was superseded by #8463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants