Move MIME field iterator from MIMEHdr to MIMEHdrImpl#8467
Merged
SolidWallOfCode merged 1 commit intoapache:masterfrom Nov 6, 2021
Merged
Move MIME field iterator from MIMEHdr to MIMEHdrImpl#8467SolidWallOfCode merged 1 commit intoapache:masterfrom
SolidWallOfCode merged 1 commit intoapache:masterfrom
Conversation
SolidWallOfCode
force-pushed
the
move-mime-field-iterator
branch
from
362f61b to
30dc43a
Compare
masaori335
approved these changes
Nov 4, 2021
Contributor
masaori335
left a comment
masaori335
left a comment
There was a problem hiding this comment.
Looks good. This is useful for plugin APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iterator should have been in that class originally. In addition, this makes it possible to use field iterators in the plugin API
which was not feasible before because the plugin API interacts with
MIMEHdrImplinstances. In turn this will enable a bit of performance tuning for field iteration in the plugin API.