fix the memory leaks #854
Closed
fix the memory leaks #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 11, 2016 18:22
[iocore/dns/test_P_DNS.cc:74]: (error) Memory leak: str
[iocore/net/test_P_Net.cc:72]: (error) Memory leak: str
There's no guarantee that delete will work on arrays. In C++ we call this undefined behaviour -- it might work, it might not, it might do something totally random and unexpected. We'd be best to avoid relying on undefined behavior. REF: http://stackoverflow.com/a/6953502
There's no guarantee that delete will work on arrays. In C++ we call this undefined behaviour -- it might work, it might not, it might do something totally random and unexpected. We'd be best to avoid relying on undefined behavior. REF: http://stackoverflow.com/a/6953502
Author
|
Buggy... will submit new PR momentarily |
bneradt
added a commit
to bneradt/trafficserver
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On line #74 'test_P_DNS.cc' has a memory leak and on line #72 'test_P_Net.cc' has a memory leak -- both of which are errors.
Found by https://github.com/bryongloden/cppcheck