Skip to content

Use Persistent Memory as storage for disk cache#8800

Closed
cukiernik wants to merge 4 commits intoapache:masterfrom
cukiernik:devdax
Closed

Use Persistent Memory as storage for disk cache#8800
cukiernik wants to merge 4 commits intoapache:masterfrom
cukiernik:devdax

Conversation

@cukiernik
Copy link
Copy Markdown
Contributor

Allows use the Intel Optane Persistent Memory as a storage for cache. It map storage directly into user space memory, so reads and writes are doing by a memcpy (without calls an io).

For configure use script tools/ipm-configure. It be need restart system probably, and run again. It configure PMem into AppDirect mode, and configure nemespaces to devdax mode. Data stored in them, be able after restart.

@cukiernik cukiernik changed the title Use PMem as storage for disk cache Use Persistent Memory as storage for disk cache Apr 20, 2022
@randall randall added this to the 10.0.0 milestone Apr 20, 2022
@cukiernik cukiernik force-pushed the devdax branch 2 times, most recently from a9090e8 to a0428c1 Compare April 25, 2022 07:44
@cukiernik
Copy link
Copy Markdown
Contributor Author

#8693

@bryancall
Copy link
Copy Markdown
Contributor

@SolidWallOfCode is going to review this

@bryancall
Copy link
Copy Markdown
Contributor

@moonchen will review this

@cukiernik
Copy link
Copy Markdown
Contributor Author

Can You help mi about RAT fail? It be ok, if I put Intel Open Source License into headers?

@bneradt
Copy link
Copy Markdown
Contributor

bneradt commented Apr 26, 2022

Can You help mi about RAT fail? It be ok, if I put Intel Open Source License into headers?

It's just alerting that some of the new files do not have valid license headers:

  • ./tools/ipm-configure
  • ./tools/ipm-performance

You can just copy and paste the license from one of the other tools files into those files. For example:

# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.


Update

Oh, I see. This patch copies content from Intel. Hmmm...it looks like their copyright is a pretty open, BSD style license? I believe what we may want to do is copy both the Intel copyright and our Apache copyright into this file. @bryancall / @zwoop : do you know what the precedent is for such copies from other source code?

@cukiernik cukiernik force-pushed the devdax branch 3 times, most recently from 98ddbf3 to 016a152 Compare April 28, 2022 08:18
@cukiernik cukiernik marked this pull request as ready for review April 28, 2022 08:41
@cukiernik cukiernik marked this pull request as draft April 28, 2022 14:09
@moonchen
Copy link
Copy Markdown
Contributor

This has been in draft for a while. Is it ready for review?

@cukiernik cukiernik force-pushed the devdax branch 2 times, most recently from aa5d58f to dff760c Compare July 8, 2022 08:21
@cukiernik cukiernik force-pushed the devdax branch 2 times, most recently from d0f0e29 to 1242f81 Compare July 22, 2022 07:39
@bryancall
Copy link
Copy Markdown
Contributor

[approve ci autest]

apt install libaio-dev
autoreconf -if
./configure --enable-mmap --enable-experimental-linux-native-aio
./configure --enable-mmap
@cukiernik cukiernik force-pushed the devdax branch 2 times, most recently from 80fce00 to b5c83b8 Compare November 18, 2022 13:35
apt install libipmctl4 libndctl6
autoreconf -if
./configure --enable-ipm=root
tools/ipm-configure
@cukiernik cukiernik marked this pull request as ready for review November 20, 2022 12:12
@zwoop zwoop added the Cache label Jan 17, 2023
@zwoop zwoop removed their request for review March 3, 2023 17:21
@ezelkow1
Copy link
Copy Markdown
Member

[approve ci centos cmake]

@bryancall
Copy link
Copy Markdown
Contributor

[approve ci]

@bryancall
Copy link
Copy Markdown
Contributor

@cukiernik is this change relevant since Intel stopped supporting Optane?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community.

@github-actions github-actions bot added the Stale label Jan 8, 2024
@github-actions github-actions bot closed this Jan 15, 2024
@zwoop zwoop removed this from the 10.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants