Expose setting some HTTP/2 tunables via sni.yaml#8818
Conversation
randall
force-pushed
the
sni-override-h2-buffer-sizes
branch
from
e85cf02 to
2725f56
Compare
bneradt
left a comment
bneradt
left a comment
There was a problem hiding this comment.
Looks fine in general. I need some help thinking through the logic and default values in proxy/http2/Http2ClientSession.cc.
proxy/http2/Http2ClientSession.cc
Outdated
| this->write_buffer = new_MIOBuffer(buffer_block_size_index); | ||
|
|
||
| uint32_t buffer_water_mark; | ||
| if (this->_vc->options.http2_buffer_water_mark != 0) { |
There was a problem hiding this comment.
Can you help me think through this: is this OK if the value is the default of -1? Or is _vc->options.http2_buffer_water_mark guaranteed to not be -1 here? I might be missing something...
There was a problem hiding this comment.
That's a good callout. I might've posted this PR in mid transition from the PR this required.
The desire is to only apply the change if the override(via sni.yaml)has been explicitly been set. Or if it's not explicitly set , to use the default from records.config.
Maybe I should use std::optional here as well instead of trying to track/remember sentinel values.
There was a problem hiding this comment.
Updated to use std::optional. I think it's clearer now
randall
force-pushed
the
sni-override-h2-buffer-sizes
branch
2 times, most recently
from
d842cb6 to
8b1da7f
Compare
randall
force-pushed
the
sni-override-h2-buffer-sizes
branch
from
8b1da7f to
b93c6cf
Compare
proxy.config.http2.default_buffer_water_mark can now be set on a per-domain basis.
randall
force-pushed
the
sni-override-h2-buffer-sizes
branch
from
b93c6cf to
2a28f3b
Compare
maskit
left a comment
maskit
left a comment
There was a problem hiding this comment.
Thank you for updating the code. I think this is going to be a great working example for those who adds similar hints. And maybe we can improve/cleanup other places with this.
|
I approved this PR, but someone else need to approve it to merge. |
proxy.config.http2.default_buffer_water_mark can now be set on a per-domain basis. (cherry picked from commit 63d09be)
|
For back porting to 9.2.x: #8875 |
* asf/9.2.x: Updated ChangeLog Update to Proxy Verifier v2.3.3 (apache#8868) Handle hit as miss when cach obj is invalid (apache#8871) Expose setting some HTTP/2 tunables via sni.yaml (apache#8818) (apache#8875)
3 participants
proxy.config.http2.default_buffer_water_mark can now be set on a
per-domain basis.