Skip to content

Conversation

@jbfavre
Copy link
Contributor

@jbfavre jbfavre commented May 24, 2022

Add missing sni.yaml and strategies.yaml man pages.

Previous list for appendices/command-line was sorted per man sections.
But, IMHO, having it sorted by file name makes list update easier.
I also tried to improve file readability in avoiding too long lines.

@bneradt
Copy link
Contributor

bneradt commented May 24, 2022

Looks like the autopep8 command fails:
https://ci.trafficserver.apache.org/job/Github_Builds/job/clang-format/1094/console

Running autopep8. This may take a minute.
autopep8 completed.
+ '[' 0 '!=' 0 ']'
+ git diff --exit-code
diff --git a/doc/manpages.py b/doc/manpages.py
index 905cc0358..84ebba95e 100644
--- a/doc/manpages.py
+++ b/doc/manpages.py
@@ -22,8 +22,8 @@ man_pages = [
     ('developer-guide/api/functions/' + filename[:-4],
         filename.split('.', 1)[0],
         filename.split('.', 1)[0] + ' API function', None, '3ts')
-        for filename in os.listdir('developer-guide/api/functions/')
-        if filename != 'index.en.rst' and filename.endswith('.rst')] + [
+    for filename in os.listdir('developer-guide/api/functions/')
+    if filename != 'index.en.rst' and filename.endswith('.rst')] + [
 
     # Add all files in the appendices/command-line directory to the list
     # of manual pages
+ '[' 0 '!=' 1 ']'
+ exit 1

We should be able to fix this by running the make autopep8 target in the build tree.

@bneradt bneradt added this to the 10.0.0 milestone May 24, 2022
@bneradt bneradt merged commit 0a33691 into apache:master May 25, 2022
@jbfavre jbfavre deleted the upstream_add_missing_man_pages branch May 25, 2022 16:08
zwoop pushed a commit that referenced this pull request May 25, 2022
* Add missing sni.yaml and strategies.yaml man pages. Improve file readability

(cherry picked from commit 0a33691)
@zwoop
Copy link
Contributor

zwoop commented May 25, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 May 25, 2022
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 16, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 23, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jul 5, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Aug 25, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Sep 19, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Nov 1, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Dec 26, 2022
Origin: other
Forwarded: apache/trafficserver#8861
Applied-Upstream: apache/trafficserver@0a33691
Last-Update: 2022-05-24

Last-Update: 2022-05-24
Gbp-Pq: Name 0017-add-missing-man-pages.patch
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Restore down nameservers after they come back online (apache#8847)
  Fix Rocky Linux 8 arm64 GCC Compiler Warnings (apache#8850)
  Fix `COMPRESSION_ERROR` on valid HPACK input (apache#8817)
  remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClientReqGet for hostname, remove pre remap continuation (apache#8362)
  Re-introduce import to get man_pages list available for sphinx. Closes apache#8858 (apache#8859)
  Add missing configuration files man pages (apache#8861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants