Make clang-format not modify ink_autoconf.h.in and ink_autoconf.h #8935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ink_autoconf.h.in and ink_autoconf.h are generated files created with autoconf. After they are made, if the user builds with them and then calls the clang-format target, clang-format will dutifully format these files according to our .clang-format specification. This then results in a future invocation of make rebuilding most of the files in the repository because those file are fundamental dependencies in our repository. This patch addresses the issue by simply not calling clang-format on these generated, not checked in, files. This fixes apache#8934
bneradt
force-pushed
the
make_initial_clang_format_not_modify_files
branch
from
2b377ac to
abf87e8
Compare
bneradt
changed the title
randall
approved these changes
Jun 30, 2022
zwoop
pushed a commit
that referenced
this pull request
Jul 6, 2022
) ink_autoconf.h.in and ink_autoconf.h are generated files created with autoconf. After they are made, if the user builds with them and then calls the clang-format target, clang-format will dutifully format these files according to our .clang-format specification. This then results in a future invocation of make rebuilding most of the files in the repository because those file are fundamental dependencies in our repository. This patch addresses the issue by simply not calling clang-format on these generated, not checked in, files. This fixes #8934 (cherry picked from commit c54fbc9)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
…ache#8935) ink_autoconf.h.in and ink_autoconf.h are generated files created with autoconf. After they are made, if the user builds with them and then calls the clang-format target, clang-format will dutifully format these files according to our .clang-format specification. This then results in a future invocation of make rebuilding most of the files in the repository because those file are fundamental dependencies in our repository. This patch addresses the issue by simply not calling clang-format on these generated, not checked in, files. This fixes apache#8934 (cherry picked from commit c54fbc9)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Updated ChangeLog trim white spaces before and after the equal sign (apache#8638) Fixes compacting spaces in S3 auth plugin (apache#8579) Fixed issues when compiling with -Og (apache#8665) Update lua plugin examples (apache#8646) Additional helper functions for request transform (apache#8631) Move ChangeLog and README.md to the lib/fastlz/ (apache#8629) Remove unused functions/definitions from ink_defs (apache#8714) Stop ATS when a global lua script fails to load (apache#8671) Change DNS retries to be a static (requires restart) config value (apache#8724) add log format for whether origin TLS connection resumed an existing TLS session (apache#8745) Update location for core rule set in modsecurity example (apache#8924) Remove unnecessary use of a memory arena when logging. (apache#8925) Add docs for remap_stats plugin (apache#8927) Allows errors from plugin initialization to bubble up (apache#8926) proxy_serve_stale: Test updates (apache#8928) Make clang-format not modify ink_autoconf.h.in and ink_autoconf.h (apache#8935) Fix clang-format installation with multiple threads (apache#8931) Add nullptr check of HTTPInfo (apache#8937)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ink_autoconf.h.in and ink_autoconf.h are generated files created with
autoconf. After they are made, if the user builds with them and then
calls the clang-format target, clang-format will dutifully format these
files according to our .clang-format specification. This then results in
a future invocation of make rebuilding most of the files in the
repository because those file are fundamental dependencies in our
repository.
This patch addresses the issue by simply not calling clang-format on
these generated, not checked in, files.
This fixes #8934