TS-4772: Add delay and max-age control to the generator plugin. #897
Conversation
|
FreeBSD build failed! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/584/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/480/ for details. |
|
FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/586/ for details. |
|
Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/481/ for details. |
|
I guess I don't have a strong opinion, but it seems unfortunate to me to introduce these new options as headers, rather than URI components. The original plugin for lighthttpd did everything in the URI paths, no? Keeping it that way seems more consistent, and easier to use for e.g. setting up various performance and load patters where you want to mix various options for various requests. In a sense, it'd cool to mimic some of the behavior of httpbin. |
|
Instead of headers I would like to seem them in the URL. Possibly as query parameters. |
|
It is done in headers so that you can trivially hit the same URL with different attributes. For example, hit URL1 with a short MaxAge to populate the cache. Then hit URL1 again with a long delay to lock the cache entry, then hit URL1. This is much harder to do with query parameters, though I have no objection to adding them as an additional mechanism. |
|
Are we good with headers (at least for now)? |
|
I dislike the inconsistency, but your explanation / use case makes a lot of sense. And if we agree that this makes things better, and not worse, do it. Maybe file a Jira to have a future addition to support both headers and URIs for all parameters? |
I got a review comment asking me to handle the Content-Length size in the plugin rather than in the HttpSM. This change pulls that in here to keep our internal release in parity with ASF.
* header_rewrite: Don't check URLs in request lines * header_rewrite: Don't check URLs in request lines * ip_allow: Skip all existing tests for UDS and add a new test that uses PP * Fix indentation
4 participants
No description provided.