TS-4746: ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak#902
Closed
keith2008 wants to merge 4 commits intoapache:masterfrom
Closed
TS-4746: ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak#902keith2008 wants to merge 4 commits intoapache:masterfrom
keith2008 wants to merge 4 commits intoapache:masterfrom
Conversation
…rst parent is not set
…ich will cause memery leak
Contributor
|
Just to be picky, but we should avoid typos in the commit messages (memory, not memory). I also think this could be simplified to just e.g. 4746 Fixes ParentRecord *secondary_parents memory leak |
Contributor
|
Also, I'm pretty sure this would fail the CI build, please run "make clang-format" on the code, and push this again with the updated commit message. Thanks! |
Contributor
|
I don't think the NULL check on the pointer is required as ats_free does that under the hood. |
Contributor
|
Closing this PR on behalf of keith2008 due to merge conflicts. I am creating a new PR for this. |
bneradt
pushed a commit
to bneradt/trafficserver
that referenced
this pull request
Feb 9, 2024
argc,argv wasn't properly set to let the remap getopt handle them correctly. This fix set the right value and pointer for the getopt to work with. (cherry picked from commit b0bf17d) Co-authored-by: Damian Meden <dmeden@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParentRecord *secondary_parents malloc, but no place free,which will cause memery leak