Allocator that just uses malloc and bypasses custom jemalloc/freelist#9108
Merged
cmcfarlen merged 1 commit intoapache:masterfrom Oct 11, 2022
Merged
Allocator that just uses malloc and bypasses custom jemalloc/freelist#9108cmcfarlen merged 1 commit intoapache:masterfrom
cmcfarlen merged 1 commit intoapache:masterfrom
Conversation
Contributor
|
So if I'm understanding this correct, this is mostly for when |
Contributor
Author
|
Yes, this shows a modest performance increase over Since this just uses the standard C memory calls, it would work with mimalloc as well but might have to include the overrides header. |
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Oct 13, 2022
…ists (apache#9108) Co-authored-by: Chris McFarlen <cmcfarlen@apple.com>
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Sep 26, 2023
…ists (apache#9108) Co-authored-by: Chris McFarlen <cmcfarlen@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reimplements Allocator to just use malloc/free and completely ignores the ink_freelist code. It doesn't disable ProxyAllocator freelists. This means the -F (proxy allocator disable) works, but -f (disable freelist) does nothing.
This differs from the -f option (when jemalloc is enabled) in the following ways:
To use this allocator, one must pass
--enable-malloc-allocatortoconfigureotherwise it will behave as it always has.