apache · randall · Feb 3, 2023 · Feb 2, 2023
diff --git a/configure.ac b/configure.ac
@@ -1250,7 +1250,7 @@ TS_CHECK_CRYPTO
 # Check for OpenSSL Version
 TS_CHECK_CRYPTO_VERSION
 
-# Check for OpenSSL Version 3 and add compatiblity define if needed
+# Check for OpenSSL Version 3 and add compatibility define if needed
 TS_CHECK_OPENSSL3
 AM_CONDITIONAL([OPENSSL_IS_OPENSSL3], [test -n "$openssl_is_openssl3"])
 

diff --git a/doc/admin-guide/files/records.yaml.en.rst b/doc/admin-guide/files/records.yaml.en.rst
@@ -470,7 +470,7 @@ Network
    ``default_inactivity_timeout`` is a connection level concept. This is not
    necessarily a problem, but it does mean that care must be taken when
    applying the override to consider that all transactions in the connection
-   which has this timeout overriden will be impacted by the override. For
+   which has this timeout overridden will be impacted by the override. For
    instance, if the default inactivity timeout is being overridden via a
    :ref:`admin-plugins-conf-remap` rule in :file:`remap.config`, then all
    transactions for that connection will be impacted by the override, not just
@@ -4010,7 +4010,7 @@ Client-Related Configuration
    ================================ ======================================================================
    ``""``                           No ALPN extension is sent by |TS| in origin-side TLS handshakes.
                                     |TS| will assume an HTTP/1.1 connection in this case.
-   ``"http/1.1"``                   Only HTTP/1.1 is advertized by |TS|. Thus, the origin will
+   ``"http/1.1"``                   Only HTTP/1.1 is advertised by |TS|. Thus, the origin will
                                     either negotiate HTTP/1.1, or it will fail the handshake if that
                                     is not supported by the origin.
    ``"http/1.1,http/1.0"``          Both HTTP/1.1 and HTTP/1.0 are supported by |TS|, but HTTP/1.1
@@ -4019,7 +4019,7 @@ Client-Related Configuration
                                     origin supports HTTP/2, it will be used for the connection. If
                                     not, it will fall back to HTTP/1.1 or, if that is not supported,
                                     HTTP/1.0. (HTTP/2 to origin is currently not supported by |TS|.)
-   ``"h2"``                         |TS| only advertizes HTTP/2 support. Thus, the origin will
+   ``"h2"``                         |TS| only advertises HTTP/2 support. Thus, the origin will
                                     either negotiate HTTP/2 or fail the handshake. (HTTP/2 to origin
                                     is currently not supported by |TS|.)
    ================================ ======================================================================

diff --git a/doc/admin-guide/plugins/header_rewrite.en.rst b/doc/admin-guide/plugins/header_rewrite.en.rst
@@ -838,7 +838,7 @@ The available controllers are:
 ================ ====================================================================
 Controller       Description
 ================ ====================================================================
-LOGGING          Turns off logging for the transction (default: ``on``)
+LOGGING          Turns off logging for the transaction (default: ``on``)
 INTERCEPT_RETRY  Allow intercepts to be retried (default: ``off``)
 RESP_CACHEABLE   Force the response to be cacheable (default: ``off``)
 REQ_CACHEABLE    Force the request to be cacheable (default: ``off``)

diff --git a/doc/conf.py b/doc/conf.py
@@ -486,7 +486,7 @@ def __init__(self, builder, *args, **kwds):
 # The format is a list of tuples containing the path and title.
 #epub_pre_files = []
 
-# HTML files shat should be inserted after the pages created by sphinx.
+# HTML files should be inserted after the pages created by sphinx.
 # The format is a list of tuples containing the path and title.
 #epub_post_files = []
 

diff --git a/doc/developer-guide/api/functions/TSSslSecret.en.rst b/doc/developer-guide/api/functions/TSSslSecret.en.rst
@@ -55,7 +55,7 @@ Description
 ===========
 
 :func:`TSSslSecretGet` fetches the named secret from the current secret map.  If there is no secret with the
-given name, the returned pointer will be null, and the :arg:`secret_data_length` output paramter will be set to zero.  If
+given name, the returned pointer will be null, and the :arg:`secret_data_length` output parameter will be set to zero.  If
 the returned pointer is not null, it points to a buffer containing the secret data.  The :arg:`secret_data_length` output
 parameter will be set to the length of the secret data.  The buffer containing the data must be freed by
 calling :func:`TSfree`.

diff --git a/doc/developer-guide/core-architecture/hostdb.en.rst b/doc/developer-guide/core-architecture/hostdb.en.rst
@@ -174,7 +174,7 @@ This version has several major architectural changes from the previous version.
    provides a noticeable simplification of the code.
 
 *  Single and multiple address results are treated identically - a singleton is simply a multiple
-   of size 1. This yeilds a major simplification of the implementation.
+   of size 1. This yields a major simplification of the implementation.
 
 *  Connections are throttled to dead upstreams, allowing only a single connection attempt per fail
    window timing until a connection succeeds.

diff --git a/doc/developer-guide/jsonrpc/jsonrpc-api.en.rst b/doc/developer-guide/jsonrpc/jsonrpc-api.en.rst
@@ -323,11 +323,11 @@ The following errors could be generated when requesting record from the server.
 
    .. enumerator:: RECORD_WRITE_ERROR = 2006
 
-      Generic error while writting the record. ie: RecResetStatRecord() returns  REC_ERR_OKAY
+      Generic error while writing the record. ie: RecResetStatRecord() returns  REC_ERR_OKAY
 
    .. enumerator:: REQUESTED_TYPE_MISMATCH = 2007
 
-      The requested record's type does not match againts the passed type list.
+      The requested record's type does not match against the passed type list.
 
    .. enumerator:: INVALID_INCOMING_DATA = 2008
 

diff --git a/doc/developer-guide/plugins/example-plugins/denylist/setting-a-global-hook.en.rst b/doc/developer-guide/plugins/example-plugins/denylist/setting-a-global-hook.en.rst
@@ -33,6 +33,6 @@ Above, ``TS_HTTP_OS_DNS_HOOK`` is the ID for the origin server DNS
 lookup hook and ``contp`` is the parent continuation created earlier.
 
 This means that the Denylist plugin is called at every origin server
-DNS lookup. When it is called, the handler functio ``denylist_plugin``
+DNS lookup. When it is called, the handler function ``denylist_plugin``
 receives ``TS_EVENT_HTTP_OS_DNS`` and calls ``handle_dns`` to see if the
 request is forbidden.
diff --git a/doc/locale/ja/LC_MESSAGES/admin-guide/plugins/ts_lua.en.po b/doc/locale/ja/LC_MESSAGES/admin-guide/plugins/ts_lua.en.po
@@ -2630,7 +2630,7 @@ msgstr ""
 
 #: ../../../admin-guide/plugins/ts_lua.en.rst:2872
 msgid ""
-"**description:** This function can be used to retireve the value of control "
+"**description:** This function can be used to retrieve the value of control "
 "channel."
 msgstr ""
 
@@ -2662,7 +2662,7 @@ msgstr ""
 
 #: ../../../admin-guide/plugins/ts_lua.en.rst:2921
 msgid ""
-"**description:** This function can be used to retireve the various "
+"**description:** This function can be used to retrieve the various "
 "milestone times. They are how long the transaction took to traverse "
 "portions of the HTTP state machine. Each milestone value is a fractional "
 "number of seconds since the beginning of the transaction."

diff --git a/doc/locale/ja/LC_MESSAGES/developer-guide/architecture/architecture.en.po b/doc/locale/ja/LC_MESSAGES/developer-guide/architecture/architecture.en.po
@@ -122,7 +122,7 @@ msgstr "二つのキャッシュスパン"
 msgid ""
 "This storage organized into a set of :term:`cache volumes <cache volume>` "
 "which are defined in :file:`volume.config`. These are the units that are "
-"used for all other administator level configuration."
+"used for all other administrator level configuration."
 msgstr ""
 "このストレージは一組の :term:`キャッシュボリューム` で構成されます。 :term:`"
 "キャッシュボリューム` は :file:`volume.config` で定義されます。これらは全て"

diff --git a/doc/locale/ja/LC_MESSAGES/developer-guide/documentation/conventions.en.po b/doc/locale/ja/LC_MESSAGES/developer-guide/documentation/conventions.en.po
@@ -182,7 +182,7 @@ msgstr ""
 
 #: ../../developer-guide/documentation/conventions.en.rst:117
 msgid ""
-"Explicityly numbered ordered lists should be avoided. |RST| provides two "
+"Explicitly numbered ordered lists should be avoided. |RST| provides two "
 "methods of marking up ordered, numbered lists, and the automatic numbering "
 "form should be used in all cases where surrounding paragraphs do not need "
 "to reference individual list entries."

diff --git a/...LC_MESSAGES/developer-guide/plugins/example-plugins/blacklist/setting-a-global-hook.en.po b/...LC_MESSAGES/developer-guide/plugins/example-plugins/blacklist/setting-a-global-hook.en.po
@@ -49,7 +49,7 @@ msgstr ""
 #: ../../developer-guide/plugins/example-plugins/blacklist/setting-a-global-hook.en.rst:35
 msgid ""
 "This means that the Blacklist plugin is called at every origin server DNS "
-"lookup. When it is called, the handler functio ``blacklist_plugin`` "
+"lookup. When it is called, the handler function ``blacklist_plugin`` "
 "receives ``TS_EVENT_HTTP_OS_DNS`` and calls ``handle_dns`` to see if the "
 "request is forbidden."
 msgstr ""
diff --git a/include/records/I_RecHttp.h b/include/records/I_RecHttp.h
@@ -545,6 +545,6 @@ extern void ts_session_protocol_well_known_name_indices_init();
  *
  * TODO: ideally this would take a ts::TextView for @a protocols, but currently
  * ts::TextView does not have a char* constructor while std::string_view does.
- * Once that is added, this can be seemlessly switched to a ts::TextView.
+ * Once that is added, this can be seamlessly switched to a ts::TextView.
  */
 bool convert_alpn_to_wire_format(std::string_view protocols, unsigned char *wire_format_buffer, int &wire_format_buffer_len);
diff --git a/include/shared/rpc/RPCRequests.h b/include/shared/rpc/RPCRequests.h
@@ -34,7 +34,7 @@
 namespace shared::rpc
 {
 struct JSONRPCRequest {
-  std::string jsonrpc{"2.0"}; //!< Always 2.0 as this is the only version that teh server supports.
+  std::string jsonrpc{"2.0"}; //!< Always 2.0 as this is the only version that the server supports.
   std::string method;         //!< remote method name.
   std::string id;             //!< optional, only needed for method calls.
   YAML::Node params;          //!< This is defined by each remote API.
@@ -49,7 +49,7 @@ struct JSONRPCRequest {
 };
 
 struct JSONRPCResponse {
-  std::string id;      //!< Always 2.0 as this is the only version that teh server supports.
+  std::string id;      //!< Always 2.0 as this is the only version that the server supports.
   std::string jsonrpc; //!< Always 2.0
   YAML::Node result; //!< Server's response, this could be decoded by using the YAML::convert mechanism. This depends solely on the
                      //!< server's data. Check docs and schemas.

diff --git a/include/ts/ts.h b/include/ts/ts.h
@@ -2831,7 +2831,7 @@ tsapi TSReturnCode TSRPCHandlerDone(TSYaml resp);
  * call.
  * @param code Error code.
  * @param descr A text with a description of the error.
- * @param descr_len The length of the descrition string.
+ * @param descr_len The length of the description string.
  * @note The @c code and @c descr will be part of the @c 'data' field in the jsonrpc error response.
  * @return TS_SUCCESS if no issues. TS_ERROR otherwise.
  */

diff --git a/include/tscore/Diags.h b/include/tscore/Diags.h
@@ -170,7 +170,7 @@ is_dbg_ctl_enabled(DbgCtl const &ctl)
 }
 
 // printf-line debug output.  First parameter must be DbgCtl instance. Assumes debug control is enabled, and
-// debug output globablly enabled.
+// debug output globally enabled.
 //
 #define DbgPrint(CTL, ...)                                                             \
   do {                                                                                 \

diff --git a/include/tscore/Regex.h b/include/tscore/Regex.h
@@ -70,7 +70,7 @@ class Regex
   /** Execute the regular expression.
    *
    * @param str String to match against.
-   * @return @c true if the patter matched, @a false if not.
+   * @return @c true if the pattern matched, @a false if not.
    *
    * It is safe to call this method concurrently on the same instance of @a this.
    */
@@ -81,7 +81,7 @@ class Regex
    * @param str String to match against.
    * @param ovector Capture results.
    * @param ovecsize Number of elements in @a ovector.
-   * @return @c true if the patter matched, @a false if not.
+   * @return @c true if the pattern matched, @a false if not.
    *
    * It is safe to call this method concurrently on the same instance of @a this.
    *

diff --git a/include/tscpp/util/TsSharedMutex.h b/include/tscpp/util/TsSharedMutex.h
@@ -188,7 +188,7 @@ class shared_mutex
     L_Fatal("%s(%p) failed: %s (%d)", func_name, ptr, Strerror(errnum).c_str(), errnum);
   }
 
-  // In debug builds, make sure shared vs. exlusive locks and unlocks are properly paired.
+  // In debug builds, make sure shared vs. exclusive locks and unlocks are properly paired.
   //
   X(std::atomic<bool> _exclusive{false};)
   X(std::atomic<int> _shared{0};)

diff --git a/iocore/eventsystem/I_Continuation.h b/iocore/eventsystem/I_Continuation.h
@@ -78,7 +78,7 @@ continuation_handler_void_ptr(int (C::*fp)(int, T *))
   // with multiple inheritance of the C templated type. Make sure that for type
   // C the Continuation parent is listed first (either directly or indirectly
   // via the inheritance tree) before any other parent in the multiple class
-  // heirarchy of C.
+  // hierarchy of C.
   return static_cast<ContinuationHandler>(fp2);
 }
 

diff --git a/iocore/eventsystem/I_EThread.h b/iocore/eventsystem/I_EThread.h
@@ -453,7 +453,7 @@ class EThread : public Thread
       static constexpr unsigned N_STAT_ID = unsigned(STAT_ID::LOOP_TIME_MAX) + 1;
 
       /// Statistic name stems.
-      /// These will be qualfied by time scale.
+      /// These will be qualified by time scale.
       static char const *const STAT_NAME[N_STAT_ID];
 
       Slice() = default;

diff --git a/iocore/hostdb/HostDB.cc b/iocore/hostdb/HostDB.cc
@@ -1467,7 +1467,7 @@ HostDBContinuation::updateHostFileConfig()
 
 //
 // Background event
-// Increment the hostdb_current_timestamp which funcions as our cached version
+// Increment the hostdb_current_timestamp which functions as our cached version
 // of ts_clock::now().  Might do other stuff here, like move records to the
 // current position in the cluster.
 int

diff --git a/iocore/hostdb/HostFile.cc b/iocore/hostdb/HostFile.cc
@@ -105,7 +105,7 @@ ParseHostFile(ts::file::path const &path, ts_seconds interval)
       // Common loading function for creating a record from the address vector.
       auto loader = [](ts::TextView key, std::vector<IpAddr> const &v) -> HostDBRecord::Handle {
         HostDBRecord::Handle record{HostDBRecord::alloc(key, v.size())};
-        record->af_family = v.front().family(); // @a v is presumed family homogenous
+        record->af_family = v.front().family(); // @a v is presumed family homogeneous
         auto rr_info      = record->rr_info();
         auto spot         = v.begin();
         for (auto &item : rr_info) {

diff --git a/iocore/hostdb/I_HostDBProcessor.h b/iocore/hostdb/I_HostDBProcessor.h
@@ -341,7 +341,7 @@ class HostDBRecord : public RefCountObj
   ts_time ip_timestamp;
 
   /// Valid duration of the DNS response data.
-  /// In the code this functions as the TTL in HostDB calcuations, but may not
+  /// In the code this functions as the TTL in HostDB calculations, but may not
   /// be the response's TTL based upon configuration such as
   /// proxy.config.hostdb.ttl_mode.
   ts_seconds ip_timeout_interval;
@@ -466,7 +466,7 @@ class HostDBRecord : public RefCountObj
    * @return The current index.
    *
    * @note The internal index may be out of range due to concurrency constraints - this insures the
-   * returned valu is in range.
+   * returned value is in range.
    */
   unsigned short rr_idx() const;
 

diff --git a/iocore/net/TLSEarlyDataSupport.cc b/iocore/net/TLSEarlyDataSupport.cc
@@ -1,6 +1,6 @@
 /** @file
 
-  TLSSEarlyDataSupport.cc provides implmentations for
+  TLSSEarlyDataSupport.cc provides implementations for
   TLSEarlyDataSupport methods
 
   @section license License

diff --git a/mgmt/rpc/handlers/common/RecordsUtils.h b/mgmt/rpc/handlers/common/RecordsUtils.h
@@ -82,7 +82,7 @@ std::tuple<YAML::Node, std::error_code> get_yaml_record(std::string const &name,
 /// @brief Get a Record as a YAML node using regex as name.
 ///
 /// @param regex The regex that will be used to lookup records.
-/// @param recType The record type we want to match againts the retrieved records. This could be either a single value or a bitwise
+/// @param recType The record type we want to match against the retrieved records. This could be either a single value or a bitwise
 /// value.
 /// @return std::tuple<YAML::Node, std::error_code>
 ///

diff --git a/mgmt/rpc/handlers/config/Configuration.cc b/mgmt/rpc/handlers/config/Configuration.cc
@@ -107,7 +107,7 @@ set_config_records(std::string_view const &id, YAML::Node const &params)
 {
   ts::Rv<YAML::Node> resp;
 
-  // we need the type and the udpate type for now.
+  // we need the type and the update type for now.
   using LookupContext = std::tuple<RecDataT, RecCheckT, const char *, RecUpdateT>;
 
   for (auto const &kv : params) {

diff --git a/mgmt/rpc/handlers/records/Records.cc b/mgmt/rpc/handlers/records/Records.cc
@@ -89,7 +89,7 @@ template <> struct convert<RequestRecordElement> {
       return false;
     }
 
-    // TODO: Add "type" paramater to just say, `config`, `metric`. May be handier.
+    // TODO: Add "type" parameter to just say, `config`, `metric`. May be handier.
 
     if (auto n = node[utils::RECORD_TYPES_KEY]) {
       // if it's empty should be ok, will get all of them.

diff --git a/mgmt/rpc/jsonrpc/unit_tests/test_basic_protocol.cc b/mgmt/rpc/jsonrpc/unit_tests/test_basic_protocol.cc
@@ -108,7 +108,7 @@ TEST_CASE("Register/call method", "[method]")
 {
   JsonRpcUnitTest rpc;
 
-  SECTION("Registring the method")
+  SECTION("Registering the method")
   {
     REQUIRE(rpc.add_method_handler("test_callback_ok_or_error", &test_callback_ok_or_error));
 
@@ -128,7 +128,7 @@ TEST_CASE("Register/call method - respond with errors (data field)", "[method][e
 {
   JsonRpcUnitTest rpc;
 
-  SECTION("Registring the method")
+  SECTION("Registering the method")
   {
     REQUIRE(rpc.add_method_handler("test_callback_ok_or_error", &test_callback_ok_or_error));
 
@@ -148,7 +148,7 @@ TEST_CASE("Register/call notification", "[notifications]")
 {
   JsonRpcUnitTest rpc;
 
-  SECTION("Registring the notification")
+  SECTION("Registering the notification")
   {
     REQUIRE(rpc.add_notification_handler("test_nofitication", &test_nofitication));
 

diff --git a/mgmt/rpc/server/CommBase.cc b/mgmt/rpc/server/CommBase.cc
@@ -37,7 +37,7 @@ CommInternalErrorCategory::message(int ev) const
 {
   switch (static_cast<rpc::comm::InternalError>(ev)) {
   case rpc::comm::InternalError::MAX_TRANSIENT_ERRORS_HANDLED:
-    return {"We've reach the maximun attempt on transient errors."};
+    return {"We've reach the maximum attempt on transient errors."};
   case rpc::comm::InternalError::POLLIN_ERROR:
     return {"We haven't got a POLLIN flag back while waiting"};
   case rpc::comm::InternalError::PARTIAL_READ:

diff --git a/mgmt/rpc/server/IPCSocketServer.cc b/mgmt/rpc/server/IPCSocketServer.cc
@@ -234,7 +234,7 @@ IPCSocketServer::accept(std::error_code &ec) const
   }
 
   if (ret < 0) {
-    // seems that we have reched the max retries.
+    // seems that we have reached the max retries.
     ec = InternalError::MAX_TRANSIENT_ERRORS_HANDLED;
   }
 

diff --git a/mgmt/rpc/server/unit_tests/test_rpcserver.cc b/mgmt/rpc/server/unit_tests/test_rpcserver.cc
@@ -156,7 +156,7 @@ getTemporaryDir()
   return fs::path(mkdtemp(dirNameTemplate));
 }
 
-// Handy class to avoid manually disconecting the socket.
+// Handy class to avoid manually disconnecting the socket.
 // TODO: should it also connect?
 struct ScopedLocalSocket : shared::rpc::IPCSocketClient {
   using super = shared::rpc::IPCSocketClient;

diff --git a/plugins/experimental/fastcgi/src/Readme b/plugins/experimental/fastcgi/src/Readme
@@ -47,7 +47,7 @@ OR Build and install using Makefile utility:
 # 1. ATS_SRC		--either set or export env variable path to traffic server src directory
 # 2. ATS_EXEC       --either set or export env variable path to traffic server exec directory
 
-  Afterwords command, $> make && sudo -E make install
+  Afterwards command, $> make && sudo -E make install
   For example:
   make ATS_SRC=/home/oschaaf/code/apache/trafficserver ATS_EXEC=/usr/local/ CPPFLAGS=-std=c++11
 

diff --git a/plugins/experimental/otel_tracer/tracer_common.h b/plugins/experimental/otel_tracer/tracer_common.h
@@ -84,7 +84,7 @@ template <typename T> class HttpTextMapCarrier : public context::propagation::Te
 };
 
 // this object is created using placement new therefore all destructors needs
-// to be called explictly inside Destruct method
+// to be called explicitly inside Destruct method
 struct ExtraRequestData {
   nostd::shared_ptr<trace::Span> span;
 

diff --git a/plugins/experimental/parent_select/consistenthash.cc b/plugins/experimental/parent_select/consistenthash.cc
@@ -161,7 +161,7 @@ PLNextHopConsistentHash::PLNextHopConsistentHash(const std::string_view name, co
       p->group_index = host_groups[i][j]->group_index;
       p->host_index  = host_groups[i][j]->host_index;
       hash_ring->insert(p, p->weight, &hash);
-      PL_NH_Debug(PL_NH_DEBUG_TAG, "Loading hash rings - ring: %d, host record: %d, name: %s, hostname: %s, stategy: %s", i, j,
+      PL_NH_Debug(PL_NH_DEBUG_TAG, "Loading hash rings - ring: %d, host record: %d, name: %s, hostname: %s, strategy: %s", i, j,
                   p->name, p->hostname.c_str(), strategy_name.c_str());
     }
     hash.clear();

diff --git a/plugins/experimental/rate_limit/ip_reputation.h b/plugins/experimental/rate_limit/ip_reputation.h
@@ -84,7 +84,7 @@ using HashMap = std::unordered_map<KeyClass, SieveBucket::iterator>; // The hash
 class SieveLru
 {
 public:
-  SieveLru() : _lock(TSMutexCreate()){}; // The unitialized version
+  SieveLru() : _lock(TSMutexCreate()){}; // The uninitialized version
   SieveLru(uint32_t num_buckets, uint32_t size);
   ~SieveLru()
   {

diff --git a/plugins/experimental/rate_limit/sni_limiter.h b/plugins/experimental/rate_limit/sni_limiter.h
@@ -57,7 +57,7 @@ class SniRateLimiter : public RateLimiter<TSVConn>
 
 private:
   // ToDo: These should be moved to global configurations to have one shared IP Reputation.
-  // today the configuration of this is so klunky, that there is no easy way to make it "global".
+  // today the configuration of this is so clunky, that there is no easy way to make it "global".
   std::chrono::seconds _iprep_max_age       = std::chrono::seconds::zero(); // Max age in the SieveLRUs for regular buckets
   std::chrono::seconds _iprep_perma_max_age = std::chrono::seconds::zero(); // Max age in the SieveLRUs for perma-block buckets
   uint32_t _iprep_num_buckets               = 10;                           // Number of buckets. ToDo: leave this at 10 always