Skip to content

Still load legacy config if it exists instead of failing#9377

Closed
cmcfarlen wants to merge 2 commits intoapache:masterfrom
cmcfarlen:whynotboth
Closed

Still load legacy config if it exists instead of failing#9377
cmcfarlen wants to merge 2 commits intoapache:masterfrom
cmcfarlen:whynotboth

Conversation

@cmcfarlen
Copy link
Copy Markdown
Contributor

Everything is broken and I'm not prepared for records.yaml

@cmcfarlen cmcfarlen added this to the 10.0.0 milestone Feb 3, 2023
@cmcfarlen cmcfarlen requested a review from brbzull0 February 3, 2023 14:54
@DoingTheNeedful
Copy link
Copy Markdown

Thanks, @cmcfarlen - swapping from a format that's been in use for years to yaml necessitates a change of a ton of tooling. The prior change would have been breaking for just about every org that uses ATS, with a significant investment in trying to change every part of build, validation, and config management. Even if you believe that swapping to yaml would be better, you cannot expect that to be a minor change.

@@ -1,32 +0,0 @@
'''
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing this?? In any case we can just:

Test.SkipIf(Condition.true("..."))

@brbzull0
Copy link
Copy Markdown
Contributor

brbzull0 commented Feb 3, 2023

We have already talked about this on slack but just for the record:
As discussed(dev and user mailing list) before, we agreed to have single parsing and fail if the legacy file is found. As also requested, a tool is provided for the translation with a guide on how to move on.
I have no issues with having it dual but just making sure that we are all on the same page.

If there is anything I can do to make the process easy just let me know and I'll do it.

@brbzull0
Copy link
Copy Markdown
Contributor

brbzull0 commented Feb 6, 2023

I've created an issue to track a solution for this, regardless of what we do with this.

#9384

@bryancall bryancall marked this pull request as draft February 7, 2023 00:14
@bryancall
Copy link
Copy Markdown
Contributor

We talked about this in the PR/issue scrub and would like to have a discussion at next weeks PR/issue scrub. A final decision should go to the mailing list. Marking it as a draft, so it doesn't get merged in before we discuss.

@cmcfarlen
Copy link
Copy Markdown
Contributor Author

I'm going to close this and we can work on the yaml support around tooling instead.

@cmcfarlen cmcfarlen closed this Feb 7, 2023
@zwoop zwoop removed this from the 10.0.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants