Fix stack overflow on sending UDP packets#9381
Merged
maskit merged 1 commit intoapache:masterfrom Feb 7, 2023
Merged
Conversation
zwoop
approved these changes
Feb 4, 2023
bryancall
approved these changes
Feb 7, 2023
bryancall
reviewed
Feb 7, 2023
| packets[npackets++] = p; | ||
| next_pkt: | ||
| if (bytesThisPipe < 0 && npackets == N_MAX_PACKETS) { | ||
| if (bytesThisPipe < 0 || npackets == N_MAX_PACKETS) { |
Contributor
There was a problem hiding this comment.
= seems safer, but it really shouldn't matter
moleksy
pushed a commit
to moleksy/trafficserver
that referenced
this pull request
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check is simply wrong. It has to break out from the loop if
npacketsreaches the limit.