Skip to content

TS-4402: Fixes some config "Int" types to "Byte" types. #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zwoop merged 2 commits into from
Sep 1, 2016
Merged

TS-4402: Fixes some config "Int" types to "Byte" types. #953

zwoop merged 2 commits into from
Sep 1, 2016

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Sep 1, 2016

This also makes some reordering of the Byte types to be consistent.

@zwoop zwoop added this to the 7.0.0 milestone Sep 1, 2016
@atsci
Copy link

atsci commented Sep 1, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/662/ for details.

@atsci
Copy link

atsci commented Sep 1, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/557/ for details.

@zwoop
Copy link
Contributor Author

zwoop commented Sep 1, 2016

I have an update to this coming momentarily. :)

@atsci
Copy link

atsci commented Sep 1, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/666/ for details.

@atsci
Copy link

atsci commented Sep 1, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/561/ for details.

@jpeach jpeach changed the title TS-4402 Fixes some config "Int" types to "Byte" types TS-4402: Fixes some config "Int" types to "Byte" types. Sep 1, 2016
@jpeach
Copy link
Contributor

jpeach commented Sep 1, 2016

This looks OK to me. Consider your commit subjects read TS-4402: ....

👍

@zwoop
Copy link
Contributor Author

zwoop commented Sep 1, 2016

@jpeach what do you mean ? The : ?

@zwoop zwoop changed the title TS-4402: Fixes some config "Int" types to "Byte" types. TS-4402 Fixes some config "Int" types to "Byte" types. Sep 1, 2016
@zwoop
Copy link
Contributor Author

zwoop commented Sep 1, 2016

Fwiw, I did compare before and after, and things definitely improved. Not a ton, but noticeable, I think we got rid of 3 cache lines in total across both structs.

@jpeach
Copy link
Contributor

jpeach commented Sep 1, 2016

Yep the :.

@atsci
Copy link

atsci commented Sep 1, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/671/ for details.

@atsci
Copy link

atsci commented Sep 1, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/566/ for details.

@zwoop zwoop changed the title TS-4402 Fixes some config "Int" types to "Byte" types. TS-4402: Fixes some config "Int" types to "Byte" types. Sep 1, 2016
@zwoop zwoop merged commit d78cd56 into apache:master Sep 1, 2016
@zwoop zwoop deleted the TS-4402 branch September 1, 2016 23:22
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 8, 2024
YTSATS-4427: handle VC_EVENT_EOS in state_common_wait_for_transform_r…
d9afd4b 
…ead (apache#953)

Add event handling for VC_EVENT_EOS in
HttpSM::state_common_wait_for_transform_read. Otherwise the handler
crashes with an assertion due to the unexpected event. This is a similar
patch to apache#948.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bryancall bryancall

Labels

Configuration

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@zwoop @atsci @jpeach @bryancall