Skip to content

TS-4805: CID 1021743: Uninitialized scalar field#955

Merged
bryancall merged 1 commit intoapache:masterfrom
bryancall:TS-4805
Sep 1, 2016
Merged

TS-4805: CID 1021743: Uninitialized scalar field#955
bryancall merged 1 commit intoapache:masterfrom
bryancall:TS-4805

Conversation

@bryancall
Copy link
Copy Markdown
Contributor

No description provided.

@atsci
Copy link
Copy Markdown

atsci commented Sep 1, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/664/ for details.

@atsci
Copy link
Copy Markdown

atsci commented Sep 1, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/559/ for details.

@zwoop zwoop added the Network label Sep 1, 2016
@zwoop zwoop added this to the 7.0.0 milestone Sep 1, 2016
@zwoop zwoop self-assigned this Sep 1, 2016
@zwoop
Copy link
Copy Markdown
Contributor

zwoop commented Sep 1, 2016

👍

Comment thread iocore/net/UnixNet.cc
transaction_no_activity_timeout_in(0),
keep_alive_no_activity_timeout_in(0),
sec(0),
cycles(0)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove sec and cycles. They aren't used AFAICT.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I was going to open another bug for that

@bryancall bryancall merged commit 01206ce into apache:master Sep 1, 2016
JosiahWI pushed a commit to JosiahWI/trafficserver that referenced this pull request Jul 8, 2024
Before this patch, I read the total number of bytes of a chain of
IOBuffers from the first buffer, instead of walking the chain. This
resulted in reading from random memory past the end of the first buffer.
This fixes this invalid read by using the API to walk a chain when
reading from an IOBufferReader.

(cherry picked from commit 72e8e4f97fb0145f9a2aa2e25b713d72e52a884e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants